[EFL] accessibility/textbox-role-reports-selection.html is failing

https://bugs.webkit.org/show_bug.cgi?id=112017

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-31
Reviewed by Mario Sanchez Prada.

Source/WebCore:

getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.

No new tests, covered by existing ones.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):

LayoutTests:

Removed failure expectations.

* platform/efl-wk1/TestExpectations: The test is no longer failing.
* platform/efl-wk2/TestExpectations: The test is no longer failing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b5e23cd0
2013-10-31 Robert Plociennik <r.plociennik@samsung.com>
[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017
Reviewed by Mario Sanchez Prada.
Removed failure expectations.
* platform/efl-wk1/TestExpectations: The test is no longer failing.
* platform/efl-wk2/TestExpectations: The test is no longer failing.
2013-10-30 Ryosuke Niwa <rniwa@webkit.org>
Add two crash expectations per bug 123555.
......
......@@ -164,7 +164,6 @@ webkit.org/b/112008 accessibility/spinbutton-value.html [ Failure ]
webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
webkit.org/b/112021 accessibility/visible-elements.html [ Failure Crash ]
......
......@@ -164,7 +164,6 @@ webkit.org/b/112008 accessibility/spinbutton-value.html [ Failure ]
webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
webkit.org/b/112021 accessibility/visible-elements.html [ Failure Crash ]
......
2013-10-31 Robert Plociennik <r.plociennik@samsung.com>
[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017
Reviewed by Mario Sanchez Prada.
getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.
No new tests, covered by existing ones.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
2013-10-31 Ryuan Choi <ryuan.choi@samsung.com>
[EFL][GLES] OpenGL should be optional
......
......@@ -518,7 +518,7 @@ static void getSelectionOffsetsForObject(AccessibilityObject* coreObject, Visibl
// Early return with proper values if the selection falls entirely out of the object.
if (!selectionBelongsToObject(coreObject, selection)) {
startOffset = comparePositions(selection.start(), firstValidPosition) < 0 ? 0 : accessibilityObjectLength(coreObject);
startOffset = comparePositions(selection.start(), firstValidPosition) <= 0 ? 0 : accessibilityObjectLength(coreObject);
endOffset = startOffset;
return;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment