Commit f17b4992 authored by eric@webkit.org's avatar eric@webkit.org

2009-08-26 Robert Sesek <rsesek@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
        https://bugs.webkit.org/show_bug.cgi?id=28670

        Change the condition regarding the key modifier check for non-contiguous
        selection on a multi-value list from just PLATFORM(MAC) to
        PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)).

        No new tests. This patch only changes the condition on which a certain mouse
        event modifier key is used.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 2298afd3
2009-08-26 Robert Sesek <rsesek@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
https://bugs.webkit.org/show_bug.cgi?id=28670
Change the condition regarding the key modifier check for non-contiguous
selection on a multi-value list from just PLATFORM(MAC) to
PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)).
No new tests. This patch only changes the condition on which a certain mouse
event modifier key is used.
* dom/SelectElement.cpp:
(WebCore::SelectElement::listBoxDefaultEventHandler):
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein
......@@ -676,7 +676,7 @@ void SelectElement::listBoxDefaultEventHandler(SelectElementData& data, Element*
data.setActiveSelectionState(true);
bool multiSelectKeyPressed = false;
#if PLATFORM(MAC)
#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))
multiSelectKeyPressed = mouseEvent->metaKey();
#else
multiSelectKeyPressed = mouseEvent->ctrlKey();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment