Commit f06a4d76 authored by eric@webkit.org's avatar eric@webkit.org
Browse files

2009-12-01 Daniel Bates <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Updated layout test to reflect change to localized string and
        rebased the result.

        * inspector/elements-img-tooltip-expected.txt:
        * inspector/elements-img-tooltip.html:
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Added missing localized strings (that I left out of the patch for bug #21554):
        %d × %d pixels
        %d × %d pixels (Natural: %d × %d pixels)

        Also, changed formatting of these stings to conform with existing ones (added
        a space on both sides of the multiply sign).

        * English.lproj/localizedStrings.js: Added stings.
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent a82ec714
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
https://bugs.webkit.org/show_bug.cgi?id=32001
Updated layout test to reflect change to localized string and
rebased the result.
* inspector/elements-img-tooltip-expected.txt:
* inspector/elements-img-tooltip.html:
2009-12-01 Adam Roben <aroben@apple.com>
 
Skip a test that fails with some versions of CFNetwork on Windows
Tests that the tooltip text for the image (below) is "215×174 pixels".
Tests that the tooltip text for the image (below) is "215 × 174 pixels".
PASSED, tooltip text is "215×174 pixels".
PASSED, tooltip text is "215 × 174 pixels".
......@@ -4,7 +4,7 @@
<script src="inspector-test.js"></script>
<script src="elements-tests.js"></script>
<script>
var EXPECTED_TOOLTIP_TEXT = "215\xd7174 pixels";
var EXPECTED_TOOLTIP_TEXT = "215 \xd7 174 pixels";
function doit()
{
function callback(tooltipText)
......
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
https://bugs.webkit.org/show_bug.cgi?id=32001
Added missing localized strings (that I left out of the patch for bug #21554):
%d × %d pixels
%d × %d pixels (Natural: %d × %d pixels)
Also, changed formatting of these stings to conform with existing ones (added
a space on both sides of the multiply sign).
* English.lproj/localizedStrings.js: Added stings.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
2009-12-01 Dave Hyatt <hyatt@apple.com>
 
Reviewed by Simon Fraser.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
......@@ -336,9 +336,9 @@ WebInspector.ElementsTreeElement.prototype = {
var tooltipText = null;
if (properties.offsetHeight === properties.naturalHeight && properties.offsetWidth === properties.naturalWidth)
tooltipText = WebInspector.UIString("%d\u00d7%d pixels", properties.offsetWidth, properties.offsetHeight);
tooltipText = WebInspector.UIString("%d × %d pixels", properties.offsetWidth, properties.offsetHeight);
else
tooltipText = WebInspector.UIString("%d\u00d7%d pixels (Natural: %d\u00d7%d pixels)", properties.offsetWidth, properties.offsetHeight, properties.naturalWidth, properties.naturalHeight);
tooltipText = WebInspector.UIString("%d × %d pixels (Natural: %d × %d pixels)", properties.offsetWidth, properties.offsetHeight, properties.naturalWidth, properties.naturalHeight);
callback(tooltipText);
}
var objectProxy = new WebInspector.ObjectProxy(node.id);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment