Commit f05a7499 authored by ap@apple.com's avatar ap@apple.com

Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=13075
        XMLHttpRequest with failed authentication should set status to 401

        https://bugs.webkit.org/show_bug.cgi?id=6871
        <rdar://problem/3363403> 401 error page is never shown

        Fix crashes in Windows DumpRenderTree.

        * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
        again on a destroyed sender.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d354c3c6
2010-07-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Fix crashes in Windows DumpRenderTree.
* DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
again on a destroyed sender.
2010-07-12 Adam Roben <aroben@apple.com>
Windows failure-to-launch fix
......
......@@ -286,7 +286,7 @@ HRESULT STDMETHODCALLTYPE ResourceLoadDelegate::didReceiveAuthenticationChalleng
if (!gLayoutTestController->handlesAuthenticationChallenges()) {
sender->continueWithoutCredentialForAuthenticationChallenge(challenge);
return E_FAIL;
return S_OK;
}
const char* user = gLayoutTestController->authenticationUsername().c_str();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment