Commit f00c0851 authored by dpranke@chromium.org's avatar dpranke@chromium.org
Browse files

2010-03-12 Dirk Pranke <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Fix new-run-webkit-tests --run-singly

        This script option is currently broken - the script attempts to
        dereference methods and variables that don't exist, which causes
        the Chromium Linux valgrind bot to be quite unhappy. This has been
        broken since r54449 when I renamed Port.start_test_driver to
        Port.start_driver.

        https://bugs.webkit.org/show_bug.cgi?id=36042

        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d1efe04a
2010-03-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Fix new-run-webkit-tests --run-singly
This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.
https://bugs.webkit.org/show_bug.cgi?id=36042
* Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
 
Fix critical being printed to stderr on every test. This is
......
......@@ -149,15 +149,15 @@ class SingleTestThread(threading.Thread):
self._output_dir = output_dir
def run(self):
driver = self._port.start_test_driver(self._image_path,
self._shell_args)
test_info = self._test_info
driver = self._port.start_driver(self._image_path, self._shell_args)
start = time.time()
crash, timeout, actual_checksum, output, error = \
driver.run_test(test_info.uri.strip(), test_info.timeout,
test_info.image_hash)
end = time.time()
self._test_stats = process_output(self._port,
self._test_info, self._test_types, self._test_args,
test_info, self._test_types, self._test_args,
self._target, self._output_dir, crash, timeout, end - start,
actual_checksum, output, error)
driver.stop()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment