Commit effcf9ce authored by beidson@apple.com's avatar beidson@apple.com

Speculative fix for:

https://bugs.webkit.org/show_bug.cgi?id=29322
and
https://bugs.webkit.org/show_bug.cgi?id=29505

Reviewed by Alexey Proskuryakov.

Adding a "Connection: close" header might make the tests work more reliably, 
and doesn't seem to make anything worse: They all continue to pass on my machine!

* http/tests/loading/resources/basic-auth-testing.php:
* http/tests/loading/resources/othersubresources/protected-resource.php:
* http/tests/loading/resources/protected-resource.php:
* http/tests/loading/resources/subresources/protected-resource.php:
* http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
* http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
* http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c97fc777
2009-09-18 Brady Eidson <beidson@apple.com>
Reviewed by Alexey Proskuryakov.
Speculative fix for:
https://bugs.webkit.org/show_bug.cgi?id=29322
and
https://bugs.webkit.org/show_bug.cgi?id=29505
Adding a "Connection: close" header might make the tests work more reliably,
and doesn't seem to make anything worse: They all continue to pass on my machine!
* http/tests/loading/resources/basic-auth-testing.php:
* http/tests/loading/resources/othersubresources/protected-resource.php:
* http/tests/loading/resources/protected-resource.php:
* http/tests/loading/resources/subresources/protected-resource.php:
* http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
* http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
* http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:
2009-09-18 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
......
......@@ -4,6 +4,7 @@ $expectedPassword = isset($_GET['password']) ? $_GET['password'] : 'password';
$realm = isset($_GET['realm']) ? $_GET['realm'] : $_SERVER['REQUEST_URI'];
header("Cache-Control: no-store");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER']) || $_SERVER['PHP_AUTH_USER'] != $expectedUsername ||
!isset($_SERVER['PHP_AUTH_PW']) || $_SERVER['PHP_AUTH_PW'] != $expectedPassword) {
header("WWW-Authenticate: Basic realm=\"" . $realm . "\"");
......
<?php
header("Cache-Control: no-store");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER'])) {
header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");
header('HTTP/1.0 401 Unauthorized');
......
<?php
header("Cache-Control: no-store");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER'])) {
header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");
header('HTTP/1.0 401 Unauthorized');
......
<?php
header("Cache-Control: no-store");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER'])) {
header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");
header('HTTP/1.0 401 Unauthorized');
......
......@@ -4,6 +4,7 @@ header("Cache-Control: no-store");
header("Last-Modified: Thu, 19 Mar 2009 11:22:11 GMT");
header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
header("Access-Control-Allow-Credentials: true");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER'])) {
header('WWW-Authenticate: Basic realm="WebKit xmlhttprequest/cross-origin-no-authorization"');
......
......@@ -3,6 +3,7 @@ header("Cache-Control: no-store");
header("Last-Modified: Thu, 19 Mar 2009 11:22:11 GMT");
header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
header("Access-Control-Allow-Credentials: true");
header("Connection: close");
$cookie = $_GET['cookie'];
if (empty($cookie)) {
......
......@@ -3,6 +3,7 @@ header("Set-Cookie: WK-cross-origin=1");
header("Cache-Control: no-store");
header("Last-Modified: Thu, 19 Mar 2009 11:22:11 GMT");
header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
header("Connection: close");
if (!isset($_SERVER['PHP_AUTH_USER'])) {
header('WWW-Authenticate: Basic realm="WebKit xmlhttprequest/cross-origin-no-authorization"');
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment