Commit ed6f43b3 authored by antti@apple.com's avatar antti@apple.com

2008-04-15 Antti Koivisto <antti@apple.com>

        Reviewed by Geoff.

        Fix <rdar://problem/5862921>
        REGRESSION: Leak in SVGSVGElement::SVGSVGElement
        
        In these strange days RefCounted starts with count of one.

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/animation/SMILTimeContainer.h:
        (WebCore::SMILTimeContainer::create):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 54328434
2008-04-15 Antti Koivisto <antti@apple.com>
Reviewed by Geoff.
Fix <rdar://problem/5862921>
REGRESSION: Leak in SVGSVGElement::SVGSVGElement
In these strange days RefCounted starts with count of one.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/animation/SMILTimeContainer.h:
(WebCore::SMILTimeContainer::create):
2008-04-15 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by hyatt
......@@ -68,7 +68,7 @@ SVGSVGElement::SVGSVGElement(const QualifiedName& tagName, Document* doc)
, m_width(this, LengthModeWidth)
, m_height(this, LengthModeHeight)
, m_useCurrentView(false)
, m_timeContainer(new SMILTimeContainer)
, m_timeContainer(SMILTimeContainer::create())
, m_viewSpec(0)
, m_containerSize(300, 150)
, m_hasSetContainerSize(false)
......
......@@ -31,6 +31,7 @@
#include "SMILTime.h"
#include "Timer.h"
#include <wtf/HashSet.h>
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
namespace WebCore {
......@@ -39,8 +40,7 @@ namespace WebCore {
class SMILTimeContainer : public RefCounted<SMILTimeContainer> {
public:
SMILTimeContainer();
static PassRefPtr<SMILTimeContainer> create() { return adoptRef(new SMILTimeContainer); }
void schedule(SVGSMILElement*);
void unschedule(SVGSMILElement*);
......@@ -55,6 +55,8 @@ namespace WebCore {
void resume();
private:
SMILTimeContainer();
void timerFired(Timer<SMILTimeContainer>*);
void startTimer(SMILTime fireTime, SMILTime minimumDelay = 0);
void updateAnimations(SMILTime elapsed);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment