Commit ed02805f authored by caio.oliveira@openbossa.org's avatar caio.oliveira@openbossa.org
Browse files

[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"

https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

* tests/testwebview.c:
(test_webkit_web_view_grab_focus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d8d1fa21
2011-08-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243
Reviewed by Martin Robinson.
The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.
This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.
* tests/testwebview.c:
(test_webkit_web_view_grab_focus):
2011-08-17 Adam Roben <aroben@apple.com>
 
Make WebCore keep track of the current device scale factor
......
......@@ -167,7 +167,7 @@ static void test_webkit_web_view_grab_focus()
loop = g_main_loop_new(NULL, TRUE);
g_signal_connect(view, "notify::progress", G_CALLBACK (idle_quit_loop_cb), NULL);
g_signal_connect(view, "notify::load-status", G_CALLBACK(idle_quit_loop_cb), NULL);
/* Wait for window to show up */
gtk_widget_show_all(window);
......@@ -235,7 +235,7 @@ static void do_test_webkit_web_view_adjustments(gboolean with_page_cache)
loop = g_main_loop_new(NULL, TRUE);
g_object_connect(G_OBJECT(view),
"signal::notify::progress", idle_quit_loop_cb, NULL,
"signal::notify::load-status", idle_quit_loop_cb, NULL,
NULL);
/* Wait for window to show up */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment