Commit ebea09c0 authored by rniwa@webkit.org's avatar rniwa@webkit.org

[Mac] Enable spellchecking tests added in r141471

https://bugs.webkit.org/show_bug.cgi?id=108525

Reviewed by Darin Adler.

Source/WebCore:

Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.

This allows us to disable automatic spelling correction in spellcheck tests.

Enabled several tests added in r141471.

* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.
* testing/Internals.h:
* testing/Internals.idl:

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.

* editing/spelling/resources/util.js:
(initSpellTest): Disable automatic text replacements.

* editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
* editing/spelling/spelling-with-underscore-selection.html: Removed.

This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.

* editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
* editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.

Ditto.

* editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
* editing/spelling/spelling-should-select-single-word.html: Removed.

Removed since this test doesn't do anything useful without the assertion for the context menu.

* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:
* editing/spelling/spelling-with-punctuation-selection-expected.txt:
* editing/spelling/spelling-with-punctuation-selection.html:
* editing/spelling/spelling-with-whitespace-selection-expected.txt:
* editing/spelling/spelling-with-whitespace-selection.html:

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 08d1be0e
2013-04-12 Ryosuke Niwa <rniwa@webkit.org>
[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525
Reviewed by Darin Adler.
Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.
* editing/spelling/resources/util.js:
(initSpellTest): Disable automatic text replacements.
* editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
* editing/spelling/spelling-with-underscore-selection.html: Removed.
This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.
* editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
* editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.
Ditto.
* editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
* editing/spelling/spelling-should-select-single-word.html: Removed.
Removed since this test doesn't do anything useful without the assertion for the context menu.
* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:
* editing/spelling/spelling-with-punctuation-selection-expected.txt:
* editing/spelling/spelling-with-punctuation-selection.html:
* editing/spelling/spelling-with-whitespace-selection-expected.txt:
* editing/spelling/spelling-with-whitespace-selection.html:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:
2013-04-12 Zoltan Arvai <zarvai@inf.u-szeged.hu>
[Qt] Unreviewed gardening.
......@@ -26,11 +26,15 @@ function initSpellTest(testElementId, testText, testFunction)
}
testFunctionCallback = testFunction;
jsTestIsAsync = true;
internals.setAutomaticSpellingCorrectionEnabled(false);
internals.settings.setAsynchronousSpellCheckingEnabled(true);
internals.settings.setSmartInsertDeleteEnabled(true);
internals.settings.setSelectTrailingWhitespaceEnabled(false);
internals.settings.setUnifiedTextCheckerEnabled(true);
internals.settings.setEditingBehavior("win");
var destination = document.getElementById(testElementId);
destination.focus();
document.execCommand("InsertText", false, testText);
......
......@@ -8,12 +8,10 @@ PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome"
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome "
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome "
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS successfullyParsed is true
TEST COMPLETE
......
Spelling should work for double-clicked misspelled words with underscores. To test manually, type 'wellcome_ home.', double-click on 'wellcome_', and context-click on the selection. The test succeeds when the context menu shows spell check suggestions.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome_"
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome_"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome_ "
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome_ "
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS successfullyParsed is true
TEST COMPLETE
wellcome_ home.
<!DOCTYPE html>
<html>
<head>
<script src="../../fast/js/resources/js-test-pre.js"></script>
<script src="resources/util.js"></script>
</head>
<body>
<div id="container">
<div id="destination" contentEditable></div>
</div>
<script>
description("Spelling should work for double-clicked misspelled words with underscores. " +
"To test manually, type 'wellcome_ home.', double-click on 'wellcome_', and context-click on the selection. " +
"The test succeeds when the context menu shows spell check suggestions.");
initSpellTest("destination", "wellcome_ home.", function(textNode) {
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "");
// Double-click the misspelled word without the trailing whitespace.
internals.settings.setSmartInsertDeleteEnabled(true);
internals.settings.setSelectTrailingWhitespaceEnabled(false);
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
eventSender.mouseUp();
eventSender.mouseDown();
eventSender.mouseUp();
shouldBeEqualToString("window.getSelection().toString()", "wellcome_");
// Context click on "wellcome_" to show the context menu.
x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome_");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
window.getSelection().removeAllRanges();
shouldBeEqualToString("window.getSelection().toString()", "");
// Double-click the misspelled word with the trailing whitespace.
internals.settings.setSmartInsertDeleteEnabled(false);
internals.settings.setSelectTrailingWhitespaceEnabled(true);
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
eventSender.mouseUp();
eventSender.mouseDown();
eventSender.mouseUp();
shouldBeEqualToString("window.getSelection().toString()", "wellcome_ ");
// Context click on "wellcome_ " to show the context menu.
x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome_ ");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
});
</script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -44,7 +44,6 @@ initSpellTest("destination", "wellcome home.", function(textNode) {
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
window.getSelection().removeAllRanges();
shouldBeEqualToString("window.getSelection().toString()", "");
......@@ -72,7 +71,6 @@ initSpellTest("destination", "wellcome home.", function(textNode) {
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome ");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
});
</script>
......
......@@ -8,10 +8,8 @@ PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome"
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS window.getSelection().toString() is "home"
PASS window.getSelection().toString() is "home"
PASS contextMenuElements[contextMenuElements.length - 1] is "<separator>"
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -33,14 +33,12 @@ initSpellTest("destination", "wellcome home.", function(textNode) {
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
// Select a correctly spelled word without surrounding whitespace or punctuation.
wordRange.setStart(textNode, 9);
......@@ -53,12 +51,10 @@ initSpellTest("destination", "wellcome home.", function(textNode) {
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 80;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
shouldBeEqualToString("window.getSelection().toString()", "home");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "<separator>");
});
</script>
......
Spell check selects the misspelled word on context click. To test manually, type 'wellcome home.' and context-click on 'wellcome'. The test succeeds when 'wellcome' is selected after the context click.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is ""
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is ""
PASS contextMenuElements[contextMenuElements.length - 1] is "<separator>"
PASS successfullyParsed is true
TEST COMPLETE
wellcome home.
<!DOCTYPE html>
<html>
<head>
<script src="../../fast/js/resources/js-test-pre.js"></script>
<script src="resources/util.js"></script>
</head>
<body>
<div id="container">
<div id="destination" contentEditable></div>
</div>
<script>
description("Spell check selects the misspelled word on context click. " +
"To test manually, type 'wellcome home.' and context-click on 'wellcome'. " +
"The test succeeds when 'wellcome' is selected after the context click.");
initSpellTest("destination", "wellcome home.", function(textNode) {
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "");
// Context click on "wellcome" to show the context menu.
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
window.getSelection().removeAllRanges();
shouldBeEqualToString("window.getSelection().toString()", "");
// Context click on "home" to show the context menu.
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 80;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
// Context click should not select correctly spelled words with "win" editing behavior.
shouldBeEqualToString("window.getSelection().toString()", "");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "<separator>");
});
</script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -8,7 +8,6 @@ PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "wellcome!"
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "wellcome!"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -33,14 +33,12 @@ initSpellTest("destination", "wellcome!", function(textNode) {
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 40;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "wellcome!");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
});
</script>
......
Underscores should be treated as whitespace: spelling should ignore them. To test manually, type 'Hi, _wellcome_ home.', select '_wellcome_', and context-click on the selection. The test succeeds when the context menu has spell check suggestions.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is ""
PASS window.getSelection().toString() is "_wellcome_"
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is "_wellcome_"
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS successfullyParsed is true
TEST COMPLETE
Hi, _wellcome_ home.
<!DOCTYPE html>
<html>
<head>
<script src="../../fast/js/resources/js-test-pre.js"></script>
<script src="resources/util.js"></script>
</head>
<body>
<div id="container">
<div id="destination" contentEditable></div>
</div>
<script>
description("Underscores should be treated as whitespace: spelling should ignore them. " +
"To test manually, type 'Hi, _wellcome_ home.', select '_wellcome_', and context-click on the selection. " +
"The test succeeds when the context menu has spell check suggestions.");
initSpellTest("destination", "Hi, _wellcome_ home.", function(textNode) {
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "");
// Select the text "_wellcome_".
var rangeWithUnderscores = document.createRange();
rangeWithUnderscores.setStart(textNode, 4);
rangeWithUnderscores.setEnd(textNode, 14);
window.getSelection().removeAllRanges();
window.getSelection().addRange(rangeWithUnderscores);
shouldBeEqualToString("window.getSelection().toString()", "_wellcome_");
// Context click on "_wellcome_" to show the context menu.
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 80;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", "_wellcome_");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
});
</script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -7,7 +7,6 @@ PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is " wellcome "
PASS spellingMarkerRange.toString() is "wellcome"
PASS window.getSelection().toString() is " wellcome "
PASS contextMenuElements[contextMenuElements.length - 1] is "welcome"
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -32,14 +32,12 @@ initSpellTest("destination", "hello, wellcome home.", function(textNode) {
var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 80;
var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
contextMenuElements = eventSender.contextClick();
// Esc key to hide the context menu.
eventSender.keyDown(String.fromCharCode(0x001B), null);
spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");
shouldBeEqualToString("window.getSelection().toString()", " wellcome ");
shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "welcome");
});
</script>
......
......@@ -1741,15 +1741,12 @@ webkit.org/b/67921 [ Release ] perf/show-hide-table-rows.html [ Failure Pass Slo
# Spellchecker behavior tests.
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
# This test has slightly networking different output on the build bots but the
......
......@@ -1310,15 +1310,12 @@ webkit.org/b/108363 fullscreen/full-screen-iframe-legacy.html [ Failure ]
# Spellchecker behavior tests.
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Failure ]
......
......@@ -165,6 +165,7 @@ svg/custom/foreignObject-crash-on-hover.xml
svg/custom/use-events-crash.svg
# [WK2] [Mac] Spellcheck tests don't seem to work
webkit.org/b/105616 editing/spelling/spelling-changed-text.html
webkit.org/b/105616 platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html [ Failure ]
webkit.org/b/105616 platform/mac/editing/spelling/click-autocorrected-word.html
webkit.org/b/105616 platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
......
......@@ -1408,19 +1408,8 @@ webkit.org/b/94198 fast/forms/input-value.html [ Failure ]
webkit.org/b/94198 fast/lists/inlineBoxWrapperNullCheck.html [ Failure ]
webkit.org/b/94198 tables/mozilla/collapsing_borders/bug41262-3.html [ Failure ]
# Spellchecker behavior tests.
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Skip ]
webkit.org/b/114470 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/114470 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/110027 compositing/transitions/transform-on-large-layer.html [ Pass ImageOnlyFailure ]
......
......@@ -820,15 +820,12 @@ editing/spelling/grammar-edit-word.html
# Spellchecker behavior tests.
# https://bugs.webkit.org/show_bug.cgi?id=108370
editing/spelling/spelling-double-clicked-word.html
editing/spelling/spelling-double-clicked-word-with-underscores.html
editing/spelling/spelling-exactly-selected-multiple-words.html
editing/spelling/spelling-exactly-selected-word.html
editing/spelling/spelling-multiword-selection.html
editing/spelling/spelling-should-select-multiple-words.html
editing/spelling/spelling-should-select-single-word.html
editing/spelling/spelling-subword-selection.html
editing/spelling/spelling-with-punctuation-selection.html
editing/spelling/spelling-with-underscore-selection.html
editing/spelling/spelling-with-whitespace-selection.html
webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Failure ]
......
......@@ -2655,15 +2655,12 @@ media/W3C/video/events/event_canplaythrough.html
# Spellchecker behavior tests.
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spellcheck-async-mutation.html [ Skip ]
webkit.org/b/108370 editing/spelling/spellcheck-async.html [ Skip ]
......
......@@ -2987,15 +2987,12 @@ fast/css3-text/css3-text-indent [ Failure ImageOnlyFailure ]
# Spellchecker behavior tests.
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-should-select-single-word.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
# Need support for ResourceHandle::didChangePriority and DRT support
......
......@@ -388,17 +388,14 @@ editing/spelling/spellcheck-attribute.html
editing/spelling/spelling-attribute-at-child.html
editing/spelling/spelling-attribute-change.html
editing/spelling/spelling-double-clicked-word.html
editing/spelling/spelling-double-clicked-word-with-underscores.html
editing/spelling/spelling-exactly-selected-multiple-words.html
editing/spelling/spelling-exactly-selected-word.html
editing/spelling/spelling-hasspellingmarker.html
editing/spelling/spelling-linebreak.html
editing/spelling/spelling-multiword-selection.html
editing/spelling/spelling-should-select-multiple-words.html
editing/spelling/spelling-should-select-single-word.html
editing/spelling/spelling-subword-selection.html
editing/spelling/spelling-with-punctuation-selection.html
editing/spelling/spelling-with-underscore-selection.html
editing/spelling/spelling-with-whitespace-selection.html
platform/mac/editing/spelling/delete-into-misspelled-word.html
platform/mac/editing/spelling/editing-multiple-words-with-markers.html
......
2013-04-12 Ryosuke Niwa <rniwa@webkit.org>
[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525
Reviewed by Darin Adler.
Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.
This allows us to disable automatic spelling correction in spellcheck tests.
Enabled several tests added in r141471.
* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.
* testing/Internals.h:
* testing/Internals.idl:
2013-04-12 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Upstream the filesystem code
......@@ -925,16 +925,26 @@ __ZN7WebCore6Editor24replaceSelectionWithTextERKN3WTF6StringEbb
__ZN7WebCore6Editor26decreaseSelectionListLevelEv
__ZN7WebCore6Editor26increaseSelectionListLevelEv
__ZN7WebCore6Editor28replaceSelectionWithFragmentEN3WTF10PassRefPtrINS_16DocumentFragmentEEEbbb
__ZN7WebCore6Editor28toggleAutomaticLinkDetectionEv
__ZN7WebCore6Editor29canDecreaseSelectionListLevelEv
__ZN7WebCore6Editor29canIncreaseSelectionListLevelEv
__ZN7WebCore6Editor29handleAlternativeTextUIResultERKN3WTF6StringE
__ZN7WebCore6Editor30deleteSelectionWithSmartDeleteEb
__ZN7WebCore6Editor30pasteAsPlainTextBypassingDHTMLEv