Commit ebc9355e authored by japhet@chromium.org's avatar japhet@chromium.org
Browse files

2010-02-22 Nate Chapin <japhet@chromium.org>

        Unreviewed, Chromium build fix.

        Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.

        CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
        that a custom named getter was needed. That hint was removed in
        http://trac.webkit.org/changeset/55104.

        * bindings/scripts/CodeGeneratorV8.pm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 17bfff94
2010-02-22 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium build fix.
Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.
CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.
* bindings/scripts/CodeGeneratorV8.pm:
2010-02-22 Alexey Proskuryakov <ap@apple.com> 2010-02-22 Alexey Proskuryakov <ap@apple.com>
Rubber-stamped by Geoff Garen. Rubber-stamped by Geoff Garen.
......
...@@ -439,7 +439,7 @@ sub GenerateHeaderNamedAndIndexedPropertyAccessors ...@@ -439,7 +439,7 @@ sub GenerateHeaderNamedAndIndexedPropertyAccessors
$hasCustomDeleterr = 0; $hasCustomDeleterr = 0;
$hasEnumerator = 0; $hasEnumerator = 0;
} }
if ($interfaceName eq "HTMLSelectElement") { if ($interfaceName eq "HTMLSelectElement" || $interfaceName eq "HTMLAppletElement" || $interfaceName eq "HTMLEmbedElement" || $interfaceName eq "HTMLObjectElement") {
$hasCustomNamedGetter = 1; $hasCustomNamedGetter = 1;
} }
my $isIndexerSpecialCase = exists $indexerSpecialCases{$interfaceName}; my $isIndexerSpecialCase = exists $indexerSpecialCases{$interfaceName};
...@@ -1414,6 +1414,10 @@ sub GenerateImplementationNamedPropertyGetter ...@@ -1414,6 +1414,10 @@ sub GenerateImplementationNamedPropertyGetter
$hasCustomGetter = 1; $hasCustomGetter = 1;
} }
if ($interfaceName eq "HTMLAppletElement" || $interfaceName eq "HTMLEmbedElement" || $interfaceName eq "HTMLObjectElement") {
$hasCustomGetter = 1;
}
my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter || $namedPropertyGetter; my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter || $namedPropertyGetter;
if (!$hasGetter) { if (!$hasGetter) {
return; return;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment