Commit ea9af864 authored by carlosgc@webkit.org's avatar carlosgc@webkit.org

REGRESSION(r159363): [GTK] API break in webkit_dom_html_media_element_set_current_time

https://bugs.webkit.org/show_bug.cgi?id=124485

Reviewed by Philippe Normand.

In r159363 currentTime attribute was changed to not raise
exceptions. This breaks the API of GObject DOM bindings because we
use a GError parameter for exceptions that has been removed.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_set_current_time): Custom
implementation that receives a GError for backwards
compatibility.
* bindings/gobject/WebKitDOMCustom.h:
* bindings/gobject/WebKitDOMCustom.symbols: Add
webkit_dom_html_media_element_set_current_time prototype.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip
webkit_dom_html_media_element_set_current_time since we are adding
a custom implementation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 75b28d30
2013-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
REGRESSION(r159363): [GTK] API break in webkit_dom_html_media_element_set_current_time
https://bugs.webkit.org/show_bug.cgi?id=124485
Reviewed by Philippe Normand.
In r159363 currentTime attribute was changed to not raise
exceptions. This breaks the API of GObject DOM bindings because we
use a GError parameter for exceptions that has been removed.
* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_set_current_time): Custom
implementation that receives a GError for backwards
compatibility.
* bindings/gobject/WebKitDOMCustom.h:
* bindings/gobject/WebKitDOMCustom.symbols: Add
webkit_dom_html_media_element_set_current_time prototype.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip
webkit_dom_html_media_element_set_current_time since we are adding
a custom implementation.
2013-11-17 Alexey Proskuryakov <ap@apple.com>
Support exporting public RSASSA-PKCS1-v1_5 keys
......
......@@ -19,6 +19,7 @@
#include "config.h"
#include "WebKitDOMCustom.h"
#include "JSMainThreadExecState.h"
#include "WebKitDOMBlob.h"
#include "WebKitDOMDOMStringList.h"
#include "WebKitDOMHTMLCollection.h"
......@@ -26,6 +27,7 @@
#include "WebKitDOMHTMLHeadElement.h"
#include "WebKitDOMHTMLInputElement.h"
#include "WebKitDOMHTMLInputElementPrivate.h"
#include "WebKitDOMHTMLMediaElementPrivate.h"
#include "WebKitDOMHTMLTextAreaElement.h"
#include "WebKitDOMHTMLTextAreaElementPrivate.h"
#include "WebKitDOMNodeList.h"
......@@ -50,6 +52,18 @@ gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement* inpu
return core(input)->lastChangeWasUserEdit();
}
void webkit_dom_html_media_element_set_current_time(WebKitDOMHTMLMediaElement* self, gdouble value, GError**)
{
#if ENABLE(VIDEO)
WebCore::JSMainThreadNullState state;
g_return_if_fail(WEBKIT_DOM_IS_HTML_MEDIA_ELEMENT(self));
WebCore::HTMLMediaElement* item = WebKit::core(self);
item->setCurrentTime(value);
#else
WEBKIT_WARN_FEATURE_NOT_PRESENT("Video")
#endif /* ENABLE(VIDEO) */
}
/* Compatibility */
WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type)
{
......
......@@ -33,6 +33,15 @@ G_BEGIN_DECLS
*/
WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* input);
/**
* webkit_dom_html_media_element_set_current_time:
* @self: A #WebKitDOMHTMLMediaElement
* @value: A #gdouble
* @error: #GError
*
*/
WEBKIT_API void webkit_dom_html_media_element_set_current_time(WebKitDOMHTMLMediaElement* self, gdouble value, GError** error);
/**
* webkit_dom_html_input_element_is_edited:
* @input: A #WebKitDOMHTMLInputElement
......
gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*)
gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*)
void webkit_dom_html_media_element_set_current_time(WebKitDOMHTMLMediaElement*, gdouble, GError**)
WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob*, gint64, gint64, const gchar*)
gchar* webkit_dom_html_element_get_class_name(WebKitDOMHTMLElement*)
void webkit_dom_html_element_set_class_name(WebKitDOMHTMLElement*, const gchar*)
......
......@@ -278,6 +278,11 @@ sub SkipFunction {
}
}
# Skip functions for which we have a custom implementation due to API breaks
if ($functionName eq "webkit_dom_html_media_element_set_current_time") {
return 1;
}
# This is for DataTransferItemList.idl add(File) method
if ($functionName eq "webkit_dom_data_transfer_item_list_add" && @{$function->parameters} == 1) {
return 1;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment