Commit e8ce9c95 authored by jochen@chromium.org's avatar jochen@chromium.org
Browse files

2011-01-15 Jochen Eisinger <jochen@chromium.org>

        Reviewed by David Levin.

        [chromium] remove obsolete createView method
        https://bugs.webkit.org/show_bug.cgi?id=52437

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        * DumpRenderTree/chromium/WebViewHost.h:
2011-01-15  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        [chromium] remove obsolete createView method
        https://bugs.webkit.org/show_bug.cgi?id=52437

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d7692ed9
2011-01-15 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
* DumpRenderTree/chromium/WebViewHost.h:
2011-01-14 Brian Weinstein <bweinstein@apple.com>
 
Reviewed by Geoff Garen.
......@@ -227,7 +227,7 @@ static string textAffinityDescription(WebTextAffinity affinity)
// WebViewClient -------------------------------------------------------------
WebView* WebViewHost::createView(WebFrame*, const WebWindowFeatures&, const WebString&)
WebView* WebViewHost::createView(WebFrame*, const WebURLRequest&, const WebWindowFeatures&, const WebString&)
{
if (!layoutTestController()->canOpenWindows())
return 0;
......
......@@ -104,7 +104,7 @@ class WebViewHost : public WebKit::WebViewClient, public WebKit::WebFrameClient,
virtual bool navigate(const TestNavigationEntry&, bool reload);
// WebKit::WebViewClient
virtual WebKit::WebView* createView(WebKit::WebFrame*, const WebKit::WebWindowFeatures&, const WebKit::WebString&);
virtual WebKit::WebView* createView(WebKit::WebFrame*, const WebKit::WebURLRequest&, const WebKit::WebWindowFeatures&, const WebKit::WebString&);
virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType);
virtual WebKit::WebWidget* createPopupMenu(const WebKit::WebPopupMenuInfo&);
virtual WebKit::WebStorageNamespace* createSessionStorageNamespace(unsigned quota);
......
2011-01-15 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437
* public/WebViewClient.h:
(WebKit::WebViewClient::createView):
2011-01-14 Xiyuan Xia <xiyuan@chromium.org>
 
Reviewed by Darin Fisher.
......@@ -80,15 +80,6 @@ class WebViewClient : virtual public WebWidgetClient {
public:
// Factory methods -----------------------------------------------------
// Create a new related WebView. This method must clone its session storage
// so any subsequent calls to createSessionStorageNamespace conform to the
// WebStorage specification.
// FIXME: This method is DEPRECATED and should be removed once the new
// createView() (the next method) is implemented at Chromium side.
virtual WebView* createView(WebFrame* creator,
const WebWindowFeatures& features,
const WebString& name) { return 0; }
// Create a new related WebView. This method must clone its session storage
// so any subsequent calls to createSessionStorageNamespace conform to the
// WebStorage specification.
......@@ -98,10 +89,7 @@ public:
const WebURLRequest& request,
const WebWindowFeatures& features,
const WebString& name) {
// FIXME: This is a temporary default implementation which calls the old
// version of createView(). Should change to 'return 0' when the old one
// is removed.
return createView(creator, features, name);
return 0;
}
// Create a new WebPopupMenu. In the second form, the client is
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment