Commit e86695c4 authored by ddkilzer@apple.com's avatar ddkilzer@apple.com

WebCore:

2008-03-20  Aaron Golden  <aegolden@gmail.com>

        Reviewed by Darin and David Kilzer.

        Addresses <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.

        Test: fast/html/marquee-scroll.html

        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::parseMappedAttribute):

LayoutTests:

2008-03-20  Aaron Golden  <aegolden@gmail.com>

        Reviewed by Darin and David Kilzer.

        - test for <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.

        * fast/html/marquee-scroll.html: Added.
        * platform/mac/fast/html/marquee-scroll-expected.checksum: Added.
        * platform/mac/fast/html/marquee-scroll-expected.png: Added.
        * platform/mac/fast/html/marquee-scroll-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ad382725
2008-03-20 Aaron Golden <aegolden@gmail.com>
Reviewed by Darin and David Kilzer.
- test for <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.
* fast/html/marquee-scroll.html: Added.
* platform/mac/fast/html/marquee-scroll-expected.checksum: Added.
* platform/mac/fast/html/marquee-scroll-expected.png: Added.
* platform/mac/fast/html/marquee-scroll-expected.txt: Added.
2008-03-19 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver.
<html>
<title>Test for marquee scrolling behavior</title>
<body>
<p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=15263">bug 15263</a>:
REGRESSION: scrolldelay=0 causes marquee not to display</p>
<p>The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string. It should scroll until the text, &quot;The marquee scroll test passed&quot is visible and left justified.</p>
<marquee width="50%" behavior="slide" bgcolor="cyan" truespeed="" scrollDelay="0">
The marquee scroll test passed
</marquee>
</body>
</html>
\ No newline at end of file
27f1543ebe9d503a8aa6c48f20cf4371
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x18
RenderText {#text} at (0,0) size 53x18
text run at (0,0) width 53: "Test for "
RenderInline {A} at (0,0) size 68x18 [color=#0000EE]
RenderText {#text} at (53,0) size 68x18
text run at (53,0) width 68: "bug 15263"
RenderText {#text} at (121,0) size 394x18
text run at (121,0) width 394: ": REGRESSION: scrolldelay=0 causes marquee not to display"
RenderBlock {P} at (0,34) size 784x36
RenderText {#text} at (0,0) size 776x36
text run at (0,0) width 776: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string."
text run at (0,18) width 557: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
RenderBlock (anonymous) at (0,86) size 784x18
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
layer at (8,94) size 392x18 scrollX -392
RenderBlock {MARQUEE} at (0,0) size 392x18 [bgcolor=#00FFFF]
RenderText {#text} at (0,0) size 192x18
text run at (0,0) width 192: "The marquee scroll test passed"
2008-03-20 Aaron Golden <aegolden@gmail.com>
Reviewed by Darin and David Kilzer.
Addresses <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.
Test: fast/html/marquee-scroll.html
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::parseMappedAttribute):
2008-03-20 Adam Roben <aroben@apple.com>
Export InspectorController::drawNodeHighlight
......@@ -102,7 +102,7 @@ void HTMLMarqueeElement::parseMappedAttribute(MappedAttribute *attr)
if (!attr->value().isEmpty())
addCSSProperty(attr, CSSPropertyWebkitMarqueeDirection, attr->value());
} else if (attr->name() == truespeedAttr)
m_minimumDelay = !attr->isNull() ? 0 : defaultMinimumDelay;
m_minimumDelay = !attr->isEmpty() ? 0 : defaultMinimumDelay;
else
HTMLElement::parseMappedAttribute(attr);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment