Commit e7e2d44a authored by haraken@chromium.org's avatar haraken@chromium.org

Rename [CustomPropertyNames] to [CustomEnumerateProperty]

https://bugs.webkit.org/show_bug.cgi?id=78351

Reviewed by Adam Barth.

This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ac019f34
2012-02-10 Kentaro Hara <haraken@chromium.org>
Rename [CustomPropertyNames] to [CustomEnumerateProperty]
https://bugs.webkit.org/show_bug.cgi?id=78351
Reviewed by Adam Barth.
This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:
2012-02-09 Antti Koivisto <antti@apple.com>
Use underlying property set to refcount PropertySetCSSStyleDeclaration
......@@ -828,7 +828,7 @@ sub GenerateHeader
}
# Custom getOwnPropertyNames function
if ($dataNode->extendedAttributes->{"CustomGetPropertyNames"} || $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) {
if ($dataNode->extendedAttributes->{"CustomEnumerateProperty"} || $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) {
push(@headerContent, " static void getOwnPropertyNames(JSC::JSObject*, JSC::ExecState*, JSC::PropertyNameArray&, JSC::EnumerationMode mode = JSC::ExcludeDontEnumProperties);\n");
$structureFlags{"JSC::OverridesGetPropertyNames"} = 1;
}
......@@ -2013,7 +2013,7 @@ sub GenerateImplementation
}
}
if (($dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) && !$dataNode->extendedAttributes->{"CustomGetPropertyNames"}) {
if (($dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) && !$dataNode->extendedAttributes->{"CustomEnumerateProperty"}) {
push(@implContent, "void ${className}::getOwnPropertyNames(JSObject* object, ExecState* exec, PropertyNameArray& propertyNames, EnumerationMode mode)\n");
push(@implContent, "{\n");
push(@implContent, " ${className}* thisObject = jsCast<${className}*>(object);\n");
......
......@@ -565,7 +565,7 @@ sub GenerateHeaderNamedAndIndexedPropertyAccessors
my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $dataNode->extendedAttributes->{"CustomNamedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasCustomDeleters = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomEnumerateProperty"};
if ($interfaceName eq "HTMLOptionsCollection") {
$interfaceName = "HTMLCollection";
$hasCustomIndexedGetter = 1;
......@@ -2160,7 +2160,7 @@ END
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasDeleter = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
my $hasEnumerator = $dataNode->extendedAttributes->{"CustomEnumerateProperty"};
my $setOn = "Instance";
# V8 has access-check callback API (see ObjectTemplate::SetAccessCheckCallbacks) and it's used on DOMWindow
......
......@@ -27,7 +27,7 @@ module css {
CustomNamedSetter,
NamedGetter,
IndexedGetter,
CustomGetPropertyNames,
CustomEnumerateProperty,
V8DependentLifetime
] CSSStyleDeclaration {
attribute [TreatReturnedNullStringAs=Null, TreatNullAs=NullString] DOMString cssText
......
......@@ -29,7 +29,7 @@ module core {
JSGenerateIsReachable=ImplElementRoot,
NamedGetter,
CustomDeleteProperty,
CustomGetPropertyNames,
CustomEnumerateProperty,
CustomNamedSetter,
] DOMStringMap {
};
......
......@@ -31,7 +31,7 @@ module window {
JSCustomDefineOwnProperty,
CustomDeleteProperty,
CustomGetOwnPropertySlot,
CustomGetPropertyNames,
CustomEnumerateProperty,
JSCustomMarkFunction,
JSCustomToNativeObject,
CustomPutFunction,
......
......@@ -33,7 +33,7 @@ module window {
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
CustomEnumerateProperty,
OmitConstructor
] History {
readonly attribute unsigned long length;
......
......@@ -36,7 +36,7 @@ module window {
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
CustomEnumerateProperty,
JSCustomDefineOwnProperty,
JSCustomPrototypePutDelegate,
JSCustomPrototypeDefineOwnProperty,
......
......@@ -29,7 +29,7 @@ module storage {
NamedGetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
CustomEnumerateProperty,
CustomNamedSetter,
] Storage {
readonly attribute [NotEnumerable] unsigned long length;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment