Commit e7ba617a authored by abarth@webkit.org's avatar abarth@webkit.org
Browse files

2010-08-24 Adam Barth <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Hulu popups are blocked
        https://bugs.webkit.org/show_bug.cgi?id=44572

        We were blocking popups created by Flash Player because we were never
        setting the UserGestureIndicator for events.  Most WebKit ports handle
        events through EventHandler, but Chromium is special (for some unknown
        reason) and dispatches events directly.  That means Chromium misses out
        on some of the work done by EventHandler, including setting the
        UserGestureIndicator.

        I suspect this is covered by an existing LayoutTest, but I don't have
        the ability to run the Chromium LayoutTests on this machine.  :(

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent aad73d3a
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Hulu popups are blocked
https://bugs.webkit.org/show_bug.cgi?id=44572
We were blocking popups created by Flash Player because we were never
setting the UserGestureIndicator for events. Most WebKit ports handle
events through EventHandler, but Chromium is special (for some unknown
reason) and dispatches events directly. That means Chromium misses out
on some of the work done by EventHandler, including setting the
UserGestureIndicator.
I suspect this is covered by an existing LayoutTest, but I don't have
the ability to run the Chromium LayoutTests on this machine. :(
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
2010-08-24 Jian Li <jianli@chromium.org>
 
Reviewed by Darin Fisher.
......
......@@ -88,6 +88,7 @@
#include "Settings.h"
#include "Timer.h"
#include "TypingCommand.h"
#include "UserGestureIndicator.h"
#include "Vector.h"
#include "WebAccessibilityObject.h"
#include "WebDevToolsAgentPrivate.h"
......@@ -980,6 +981,8 @@ const WebInputEvent* WebViewImpl::m_currentInputEvent = 0;
bool WebViewImpl::handleInputEvent(const WebInputEvent& inputEvent)
{
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
// If we've started a drag and drop operation, ignore input events until
// we're done.
if (m_doingDragAndDrop)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment