Commit e7ae6286 authored by mrobinson@webkit.org's avatar mrobinson@webkit.org
Browse files

2011-02-09 Martin Robinson <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Default error page is interfering with tests which require failed loads
        https://bugs.webkit.org/show_bug.cgi?id=54157

        Unskip passing tests and remove some bogus expected results.

        * platform/gtk/Skipped: Unskip some tests which are now passing.
        * platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Default error page is interfering with tests which require failed loads
        https://bugs.webkit.org/show_bug.cgi?id=54157

        Disable the default error page during DRT runs. This prevents unexpected loads
        from interfering with tests that have planned failed loads.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadError): Added, disable default handler.
        (createWebView): Connect the new load-error handler.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8bd79613
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Unskip passing tests and remove some bogus expected results.
* platform/gtk/Skipped: Unskip some tests which are now passing.
* platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.
2011-02-10 Philippe Normand <pnormand@igalia.com>
 
Unreviewed skip failing fast/text/international/hindi-whitespace.html test on GTK
......@@ -18,18 +18,6 @@
#
# grep -v '^#' | grep -v '^$'
# The group of tests below are timing out. As we go through them
# and get more detailed information, we should attach bugs to them.
fast/xmlhttprequest/null-document-xmlhttprequest-open.html
fast/dom/null-document-location-replace-crash.html
fast/dom/null-document-location-put-crash.html
fast/dom/null-document-location-assign-crash.html
fast/dom/null-document-location-href-put-crash.html
fast/dom/null-document-window-open-crash.html
# Fails because of timing out in the GTK 32-bit Debug bot
# (see bug https://bugs.webkit.org/show_bug.cgi?id=53992)
fast/loader/onload-willSendRequest-null-for-frame.html
# Intermittently timing out on Gtk Debug Bot:
# https://bugs.webkit.org/show_bug.cgi?id=33445
http/tests/incremental/split-hex-entities.pl
......@@ -3098,9 +3086,6 @@ plugins/invalidate_rect.html
# Need to source the "WeightWatcher" fonts for this test.
fast/css/font-weight-1.html
# https://bugs.webkit.org/show_bug.cgi?id=54183
fast/events/focusingUnloadedFrame.html
# https://bugs.webkit.org/show_bug.cgi?id=54189
fast/replaced/border-radius-clip.html
......
FAIL: Timed out waiting for notifyDone to be called
This test checks for a NULL document crash that can happen when setting location. If the test passes, you'll see a PASS message below.
......@@ -19,28 +19,8 @@ layer at (0,0) size 800x600
text run at (580,19) width 37: "Crash"
RenderText {#text} at (0,0) size 0x0
RenderFrame {FRAME} at (0,0) size 0x0
layer at (0,0) size 600x245
RenderView at (0,0) size 0x0
layer at (0,0) size 0x0
RenderBlock {HTML} at (0,0) size 0x0
RenderBody {BODY} at (0,0) size 0x0 [bgcolor=#FFFFFF]
layer at (16,32) size 584x213
RenderBlock (positioned) {DIV} at (16,32) size 584x213 [border: (2px solid #EEEEEE)]
RenderBlock {DIV} at (12,31) size 560x22
RenderBlock {P} at (0,0) size 560x22
RenderText {#text} at (0,0) size 165x22
text run at (0,0) width 165: "Unable to load page"
RenderBlock {DIV} at (12,72) size 560x69
RenderBlock {P} at (0,0) size 560x38
RenderText {#text} at (0,0) size 477x38
text run at (0,0) width 262: "Problem occurred while loading the URL"
text run at (0,19) width 477: "file:///home/martin/WebKit/LayoutTests/fast/events/resources/notfound.html"
RenderBlock {P} at (0,54) size 560x15
RenderText {#text} at (0,0) size 234x15
text run at (0,0) width 234: "Error opening file: No such file or directory"
RenderBlock {FORM} at (12,153) size 560x32
RenderButton {INPUT} at (2,2) size 83x28 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,4) size 67x19
RenderText at (0,0) size 67x19
text run at (0,0) width 67: "Try again"
RenderText {#text} at (0,0) size 0x0
RenderView at (0,0) size 0x0
layer at (0,0) size 0x8
RenderBlock {HTML} at (0,0) size 0x8
RenderBody {BODY} at (8,8) size 0x0
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Disable the default error page during DRT runs. This prevents unexpected loads
from interfering with tests that have planned failed loads.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewLoadError): Added, disable default handler.
(createWebView): Connect the new load-error handler.
2011-02-10 Zoltan Horvath <zoltan@webkit.org>
 
Reviewed by Andreas Kling.
......@@ -742,6 +742,11 @@ static void webViewLoadFinished(WebKitWebView* view, WebKitWebFrame* frame, void
dump();
}
static gboolean webViewLoadError(WebKitWebView*, WebKitWebFrame*, gchar*, gpointer, gpointer)
{
return TRUE; // Return true here to disable the default error page.
}
static void webViewDocumentLoadFinished(WebKitWebView* view, WebKitWebFrame* frame, void*)
{
if (!done && gLayoutTestController->dumpFrameLoadCallbacks()) {
......@@ -1008,6 +1013,7 @@ static WebKitWebView* createWebView()
g_object_connect(G_OBJECT(view),
"signal::load-started", webViewLoadStarted, 0,
"signal::load-finished", webViewLoadFinished, 0,
"signal::load-error", webViewLoadError, 0,
"signal::window-object-cleared", webViewWindowObjectCleared, 0,
"signal::console-message", webViewConsoleMessage, 0,
"signal::script-alert", webViewScriptAlert, 0,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment