[BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()

https://bugs.webkit.org/show_bug.cgi?id=100330

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-25
Reviewed by Rob Buis.

Reviewed internally by Charles Wei.
PR #231232

Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
visible needs AuthenticationChallengeManager to update its records, deleting
webpage from AuthenticationChallengeManager's map should be done after setting
webpage visibility.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5f60460f
......@@ -453,7 +453,6 @@ WebPage::WebPage(WebPageClient* client, const BlackBerry::Platform::String& page
WebPagePrivate::~WebPagePrivate()
{
AuthenticationChallengeManager::instance()->pageDeleted(this);
// Hand the backingstore back to another owner if necessary.
m_webPage->setVisible(false);
if (BackingStorePrivate::currentBackingStoreOwner() == m_webPage)
......@@ -494,6 +493,8 @@ WebPagePrivate::~WebPagePrivate()
delete m_dumpRenderTree;
m_dumpRenderTree = 0;
#endif
AuthenticationChallengeManager::instance()->pageDeleted(this);
}
WebPage::~WebPage()
......
2012-10-25 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
[BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
https://bugs.webkit.org/show_bug.cgi?id=100330
Reviewed by Rob Buis.
Reviewed internally by Charles Wei.
PR #231232
Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
visible needs AuthenticationChallengeManager to update its records, deleting
webpage from AuthenticationChallengeManager's map should be done after setting
webpage visibility.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
2012-10-24 Sean Wang <Xuewen.Wang@torchmobile.com.cn>
[BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment