Commit e72263c6 authored by bweinstein@apple.com's avatar bweinstein@apple.com

2009-09-17 Brian Weinstein <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        The Console scope bar should have a divider between All and the other possible
        values (Errors, Warnings, Logs). It will look something like:
        
        All | Errors Warnings Logs.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement):
        (WebInspector.ConsoleView):
        * inspector/front-end/inspector.css:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent a7e66e1d
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
The Console scope bar should have a divider between All and the other possible
values (Errors, Warnings, Logs). It will look something like:
All | Errors Warnings Logs.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.createDividerElement):
(WebInspector.ConsoleView):
* inspector/front-end/inspector.css:
2009-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
......@@ -61,6 +61,14 @@ WebInspector.ConsoleView = function(drawer)
// Will hold the list of filter elements
this.filterBarElement = document.getElementById("console-filter");
function createDividerElement() {
var dividerElement = document.createElement("div");
dividerElement.addStyleClass("divider");
this.filterBarElement.appendChild(dividerElement);
}
function createFilterElement(category) {
var categoryElement = document.createElement("li");
categoryElement.category = category;
......@@ -77,6 +85,9 @@ WebInspector.ConsoleView = function(drawer)
}
this.allElement = createFilterElement.call(this, "All");
createDividerElement.call(this);
this.errorElement = createFilterElement.call(this, "Errors");
this.warningElement = createFilterElement.call(this, "Warnings");
this.logElement = createFilterElement.call(this, "Logs");
......
......@@ -2327,6 +2327,15 @@ button.enable-toggle-status-bar-item.toggled-on .glyph {
text-shadow: rgba(255, 255, 255, 0.5) 1px 1px 0;
}
#console-filter div.divider {
margin-left: 5px;
margin-right: 5px;
/* Only want a border-left here because border on both sides
made the divider too thick */
border-left: 1px solid gray;
display: inline;
}
#resources-filter li.selected, #resources-filter li:hover, #resources-filter li:active,
#console-filter li.selected, #console-filter li:hover, #console-filter li:active {
color: white;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment