Commit e55ac89d authored by aroben@apple.com's avatar aroben@apple.com

Make run-javascriptcore-tests work with a space in the path to testkjs

        Reviewed by Alexey Proskuryakov.

        * tests/mozilla/jsDriver.pl: Quote the path to the engine so that
        spaces will be interpreted correctly.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 167d2dba
2008-05-28 Adam Roben <aroben@apple.com>
Make run-javascriptcore-tests work with a space in the path to testkjs
Reviewed by Alexey Proskuryakov.
* tests/mozilla/jsDriver.pl: Quote the path to the engine so that
spaces will be interpreted correctly.
2008-05-28 Alexey Proskuryakov <ap@webkit.org>
Fixed a misguiding comment - my measurement for negative numbers only included cases
......
......@@ -173,7 +173,10 @@ sub execute_tests {
# (only check for their existance if the suite or test_dir has changed
# since the last time we looked.)
if ($last_suite ne $suite || $last_test_dir ne $test_dir) {
$shell_command = &xp_path($engine_command) . " -s ";
# FIXME: Quoting the path this way won't work with paths with
# quotes in them. A better fix would be to use the multi-parameter
# version of open(), but that doesn't work on ActiveState Perl.
$shell_command = "\"" . &xp_path($engine_command) . "\" -s ";
$path = &xp_path($opt_suite_path . $suite . "/shell.js");
if (-f $path) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment