Commit e4dd6af8 authored by oliver's avatar oliver

2007-04-12 Oliver Hunt <oliver@apple.com>

        Reviewed by Adam.

        This fixes <rdar://problem/5060766> -- Frameset with 
        an empty frame crashes due to null document.  Debug
        builds hit the frame->document() assertion in 
        EventHandler::prepareMouseEvent

        This null check seems necessary now, having run through 
        all the logic on the path to this crash it appears that
        we can't avoid this null check.  

        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateDragAndDrop):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6f017c14
2007-04-12 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
This fixes <rdar://problem/5060766> -- Frameset with
an empty frame crashes due to null document. Debug
builds hit the frame->document() assertion in
EventHandler::prepareMouseEvent
This null check seems necessary now, having run through
all the logic on the path to this crash it appears that
we can't avoid this null check.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
2007-04-12 Justin Garcia <justin.garcia@apple.com>
Reviewed by darin
......@@ -1019,6 +1019,9 @@ bool EventHandler::updateDragAndDrop(const PlatformMouseEvent& event, Clipboard*
{
bool accept = false;
if (!m_frame->document())
return false;
MouseEventWithHitTestResults mev = prepareMouseEvent(HitTestRequest(true, false), event);
// Drag events should never go to text nodes (following IE, and proper mouseover/out dispatch)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment