Commit e4a25731 authored by bdakin@apple.com's avatar bdakin@apple.com
Browse files

WebCore:

2009-03-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326): 
        Popup menu appears at the wrong location on page at http://
        www.signonsandiego.com/

        This was a regression from http://trac.webkit.org/changeset/40769, 
        which changed the base class of RenderInline to 
        RenderBoxModelObject rather than RenderBox.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetParent): offsetParent should return a 
        RenderBoxModelObject rather than just a RenderBox, which is more 
        restrictive. 

LayoutTests:

2009-03-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326): 
        Popup menu appears at the wrong location on page at http://
        www.signonsandiego.com/

        * fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
        * fast/dom/offset-parent-positioned-and-inline.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 369e6479
2009-03-18 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/
* fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
* fast/dom/offset-parent-positioned-and-inline.html: Added.
2009-03-18 Sam Weinig <sam@webkit.org>
 
Reviewed by Simon Fraser.
......
Div Anchor
Success! This test succeeded because the div is rightly recognized as the anchor's offsetParent.
<html>
<body>
<div style="position:relative; display:inline; border:1px solid black">Div
<a id="anchor" style="border:1px solid red">Anchor</a>
</div>
<br><br>
<span id="result">FAIL! This test has failed because the offsetParent of the anchor is coming back as null :-(</span>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
var anchor = document.getElementById("anchor");
var result = document.getElementById("result");
if (anchor.offsetParent)
result.innerHTML = "Success! This test succeeded because the div is rightly recognized as the anchor's offsetParent.";
</script>
</body>
</html>
2009-03-18 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/
This was a regression from http://trac.webkit.org/changeset/40769,
which changed the base class of RenderInline to
RenderBoxModelObject rather than RenderBox.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent): offsetParent should return a
RenderBoxModelObject rather than just a RenderBox, which is more
restrictive.
2009-03-18 Anders Carlsson <andersca@apple.com>
 
Reviewed by Darin Adler.
......@@ -2290,7 +2290,7 @@ RenderBoxModelObject* RenderObject::offsetParent() const
currZoom = newZoom;
curr = curr->parent();
}
return curr && curr->isBox() ? toRenderBox(curr) : 0;
return curr && curr->isBoxModelObject() ? toRenderBoxModelObject(curr) : 0;
}
#if ENABLE(SVG)
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment