Commit e3543b8f authored by antti's avatar antti
Browse files

LayoutTests:

        Reviewed by Mitz.
        
        Test case for <rdar://problem/5058774>
        REGRESSION: In Mail, caret appears oversized when typing in a To Do note

        * editing/style/highlight-expected.checksum: Added.
        * editing/style/highlight-expected.png: Added.
        * editing/style/highlight-expected.txt: Added.
        * editing/style/highlight.html: Added.

WebCore:

        Reviewed by Mitz.
        
        Fix <rdar://problem/5058774>
        REGRESSION: In Mail, caret appears oversized when typing in a To Do note
        
        Horizontal and vertical were switched. Was regression from
        http://trac.webkit.org/projects/webkit/changeset/20103

        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::addHighlightOverflow):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 1ea6f464
2007-03-14 Antti Koivisto <antti@apple.com>
Reviewed by Mitz.
Test case for <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note
* editing/style/highlight-expected.checksum: Added.
* editing/style/highlight-expected.png: Added.
* editing/style/highlight-expected.txt: Added.
* editing/style/highlight.html: Added.
2007-03-13 Justin Garcia <justin.garcia@apple.com>
 
Reviewed by darin
5521a6ff21252670333b12883927120b
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {DIV} at (0,0) size 784x18
RenderText {#text} at (0,0) size 135x18
text run at (0,0) width 135: "some highlighted text"
caret: position 0 of child 0 {#text} of child 0 {DIV} of child 0 {BODY} of child 0 {HTML} of document
<html>
<body><div id=e contenteditable style="-webkit-highlight:'green';">some highlighted text</div>
<script>
var e = document.getElementById('e');
window.getSelection().setPosition(e,0);
</script>
</body>
</html>
\ No newline at end of file
2007-03-14 Antti Koivisto <antti@apple.com>
Reviewed by Mitz.
Fix <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note
Horizontal and vertical were switched. Was regression from
http://trac.webkit.org/projects/webkit/changeset/20103
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
2007-03-14 David Hyatt <hyatt@apple.com>
 
Tweak the data() functions of stylesheets and scripts to be internally consistent.
......
......@@ -140,8 +140,8 @@ void RootInlineBox::addHighlightOverflow()
// Highlight acts as a selection inflation.
FloatRect rootRect(0, selectionTop(), width(), selectionHeight());
IntRect inflatedRect = enclosingIntRect(object()->document()->frame()->customHighlightLineRect(object()->style()->highlight(), rootRect, object()->node()));
setVerticalOverflowPositions(min(leftOverflow(), inflatedRect.x()), max(rightOverflow(), inflatedRect.right()));
setHorizontalOverflowPositions(min(topOverflow(), inflatedRect.y()), max(bottomOverflow(), inflatedRect.bottom()));
setHorizontalOverflowPositions(min(leftOverflow(), inflatedRect.x()), max(rightOverflow(), inflatedRect.right()));
setVerticalOverflowPositions(min(topOverflow(), inflatedRect.y()), max(bottomOverflow(), inflatedRect.bottom()));
}
void RootInlineBox::paintCustomHighlight(RenderObject::PaintInfo& paintInfo, int tx, int ty, const AtomicString& highlightType)
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment