Commit e2183928 authored by loislo@chromium.org's avatar loislo@chromium.org
Browse files

Web Inspector: CPU profiler. Swap FlameChart with Data Grid.

https://bugs.webkit.org/show_bug.cgi?id=113395

Reviewed by Pavel Feldman.

Looks like FlameChart is more powerful and flexible instrument
than plain old ProfileTree in DataGrid. The same action like
'look for the most expensive function in a frame' could be easily
done with FlameChart and need number of clicks in DataGrid.
So in an offline discussion we decided to place FlameChart on top of DataGrid.

* inspector/front-end/CPUProfileView.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ae539ad0
2013-03-27 Ilya Tikhonovsky <loislo@chromium.org>
Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
https://bugs.webkit.org/show_bug.cgi?id=113395
Reviewed by Pavel Feldman.
Looks like FlameChart is more powerful and flexible instrument
than plain old ProfileTree in DataGrid. The same action like
'look for the most expensive function in a frame' could be easily
done with FlameChart and need number of clicks in DataGrid.
So in an offline discussion we decided to place FlameChart on top of DataGrid.
* inspector/front-end/CPUProfileView.js:
2013-03-27 Chris Fleizach <cfleizach@apple.com>
 
Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339
......@@ -56,11 +56,11 @@ WebInspector.CPUProfileView = function(profile)
this._splitView = new WebInspector.SplitView(false, "flameChartSplitLocation");
this._splitView.show(this.element);
this.dataGrid.show(this._splitView.firstElement());
this.flameChart = new WebInspector.FlameChart(this);
this.flameChart.addEventListener(WebInspector.FlameChart.Events.SelectedNode, this._revealProfilerNode.bind(this));
this.flameChart.show(this._splitView.secondElement());
this.flameChart.show(this._splitView.firstElement());
this.dataGrid.show(this._splitView.secondElement());
} else
this.dataGrid.show(this.element);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment