Commit e183ed1b authored by ap@apple.com's avatar ap@apple.com
Browse files

Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=54572
        REGRESSION (WebKit2): Print Backgrounds checkbox has no effect for DOM initiated printing

        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Preferences need
        to be propagated to Web process during synchronous printing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ae9fabb4
2011-02-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=54572
REGRESSION (WebKit2): Print Backgrounds checkbox has no effect for DOM initiated printing
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Preferences need
to be propagated to Web process during synchronous printing.
2011-02-15 Anders Carlsson <andersca@apple.com>
 
Reviewed by Sam Weinig.
......@@ -1178,7 +1178,9 @@ void WebPageProxy::preferencesDidChange()
// FIXME: It probably makes more sense to send individual preference changes.
// However, WebKitTestRunner depends on getting a preference change notification
// even if nothing changed in UI process, so that overrides get removed.
process()->send(Messages::WebPage::PreferencesDidChange(pageGroup()->preferences()->store()), m_pageID);
// Preferences need to be updated during synchronous printing to make "print backgrounds" preference work when toggled from a print dialog checkbox.
process()->send(Messages::WebPage::PreferencesDidChange(pageGroup()->preferences()->store()), m_pageID, m_isPerformingDOMPrintOperation ? CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply : 0);
}
#if ENABLE(TILED_BACKING_STORE)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment