Commit dfbbc17b authored by andersca's avatar andersca
Browse files

Reviewed by Geoff.

        Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8ea01da3
2007-07-26 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePage):
2007-07-26 David Hyatt <hyatt@apple.com>
 
FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
......@@ -1646,6 +1646,11 @@ bool FrameLoader::canCachePage()
&& m_documentLoader->mainDocumentError().isNull()
&& !m_frame->tree()->childCount()
&& !m_frame->tree()->parent()
// FIXME: If we ever change this so that pages with plug-ins will be cached,
// we need to make sure that we don't cache pages that have outstanding NPObjects
// (objects created by the plug-in). Since there is no way to pause/resume a Netscape plug-in,
// they would need to be destroyed and then recreated, and there is no way that we can recreate
// the right NPObjects. See <rdar://problem/5197041> for more information.
&& !m_containsPlugIns
&& !m_URL.protocol().startsWith("https")
&& m_frame->document()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment