Commit dd4a990a authored by zhajiang@rim.com's avatar zhajiang@rim.com
Browse files

[BlackBerry] Blitting wrong rect during history navigations

https://bugs.webkit.org/show_bug.cgi?id=113963

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

On www.bbc.com/news, we blit wrong rect during the second restoration
of the view states when we navigate back from stories to the main page.
Update the contents size and scroll position before we render and blit
if we failed to zoomAboutPoint so that UI thread can still get the
correct rect during blit.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ef507747
......@@ -6100,18 +6100,17 @@ void WebPagePrivate::restoreHistoryViewState(const WebCore::IntPoint& scrollPosi
m_shouldReflowBlock = shouldReflowBlock;
bool didZoom = zoomAboutPoint(scale, m_mainFrame->view()->scrollPosition(), true /* enforceScaleClamping */, true /*forceRendering*/, true /*isRestoringZoomLevel*/);
if (!zoomAboutPoint(scale, m_mainFrame->view()->scrollPosition(), true /* enforceScaleClamping */, true /*forceRendering*/, true /*isRestoringZoomLevel*/)) {
// We need to notify the client of the scroll position and content size change(s) above even if we didn't scale.
notifyTransformedContentsSizeChanged();
notifyTransformedScrollChanged();
}
// If we're already at that scale, then we should still force rendering
// since our scroll position changed.
// FIXME: Do we really need to suspend/resume both backingstore and screen here?
m_backingStore->d->resumeBackingStoreUpdates();
m_backingStore->d->resumeScreenUpdates(BackingStore::RenderAndBlit);
if (!didZoom) {
// We need to notify the client of the scroll position and content size change(s) above even if we didn't scale.
notifyTransformedContentsSizeChanged();
notifyTransformedScrollChanged();
}
}
IntSize WebPagePrivate::screenSize() const
......
2013-04-04 Jacky Jiang <zhajiang@rim.com>
[BlackBerry] Blitting wrong rect during history navigations
https://bugs.webkit.org/show_bug.cgi?id=113963
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
On www.bbc.com/news, we blit wrong rect during the second restoration
of the view states when we navigate back from stories to the main page.
Update the contents size and scroll position before we render and blit
if we failed to zoomAboutPoint so that UI thread can still get the
correct rect during blit.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
2013-04-05 Jakob Petsovits <jpetsovits@blackberry.com>
 
[BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment