Commit dd1d9f54 authored by zandobersek@gmail.com's avatar zandobersek@gmail.com
Browse files

[GTK][webkitpy] A huge list of warnings about missing bugs in expectations...

[GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
https://bugs.webkit.org/show_bug.cgi?id=113421

Reviewed by Dirk Pranke.

When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
in the GTK-specific TestExpectations files.

To avoid this only enable the warnings only when not using WKTR.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.warn_if_bug_missing_in_test_expectations):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 4fffc657
2013-03-27 Zan Dobersek <zdobersek@igalia.com>
[GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
https://bugs.webkit.org/show_bug.cgi?id=113421
Reviewed by Dirk Pranke.
When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
in the GTK-specific TestExpectations files.
To avoid this only enable the warnings only when not using WKTR.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.warn_if_bug_missing_in_test_expectations):
2013-03-27 Antti Koivisto <antti@apple.com>
 
Fix Zalan's email.
......@@ -43,7 +43,7 @@ class GtkPort(Port):
self._pulseaudio_sanitizer = PulseAudioSanitizer()
def warn_if_bug_missing_in_test_expectations(self):
return True
return not self.get_option('webkit_test_runner')
def _port_flag_for_scripts(self):
return "--gtk"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment