Commit db050d73 authored by yosin@chromium.org's avatar yosin@chromium.org

REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled

https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
* platform/chromium/test_expectations.txt: Update comment.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b7d6f802
2012-05-29 Yoshifumi Inoue <yosin@chromium.org>
REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719
Reviewed by Kent Tamura.
* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
* platform/chromium/test_expectations.txt: Update comment.
2012-05-29 Hayato Ito <hayato@chromium.org>
Refactor shadow-dom-event-dispatching.html.
......
......@@ -3778,7 +3778,7 @@ BUGWK87364 DEBUG : fast/dom/shadow/drop-event-in-shadow.html = TEXT PASS
BUGWK76809 SKIP : editing/pasteboard/data-transfer-items-drag-drop-entry.html = FAIL
BUGWK76809 SKIP : fast/filesystem/cross-filesystem-op.html = FAIL
// BUG-87719 will change image.
// Need expected image for each platform
BUGWK87614 : fast/forms/select/optgroup-rendering.html = FAIL MISSING
// Requires setUseDeferredFrameLoading() API from LayoutTestController.
......
2012-05-29 Yoshifumi Inoue <yosin@chromium.org>
REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719
Reviewed by Kent Tamura.
This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.
Test: fast/form/select/optgroup-rendering.html
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.
2012-05-29 Hayato Ito <hayato@chromium.org>
Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker.
......
......@@ -1051,7 +1051,7 @@ bool SelectorChecker::checkOneSelector(const SelectorCheckingContext& context, P
}
break;
case CSSSelector::PseudoEnabled:
if (element && (element->isFormControlElement() || element->hasTagName(optgroupTag)))
if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag)))
return element->isEnabledFormControl();
break;
case CSSSelector::PseudoFullPageMedia:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment