Commit d8bd33ac authored by pfeldman@chromium.org's avatar pfeldman@chromium.org

2011-05-03 Pavel Feldman <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename BrowserDebugger agent to DOMDebugger.
        https://bugs.webkit.org/show_bug.cgi?id=60019

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
        * inspector/generate-inspector-idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5eb3347d
2011-05-03 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename BrowserDebugger agent to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60019
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
* inspector/generate-inspector-idl:
2011-05-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
......@@ -35,7 +35,7 @@ $typeTransform{"Debugger"} = {
"header" => "InspectorDebuggerAgent.h",
"domainAccessor" => "m_debuggerAgent",
};
$typeTransform{"BrowserDebugger"} = {
$typeTransform{"DOMDebugger"} = {
"forward" => "InspectorBrowserDebuggerAgent",
"header" => "InspectorBrowserDebuggerAgent.h",
"domainAccessor" => "m_browserDebuggerAgent",
......
......@@ -1521,8 +1521,8 @@
]
},
{
"domain": "BrowserDebugger",
"description": "Browser debugging allows setting breakpoints on particular DOM operations and events. JavaScript execution will stop on these operations as if there was a regular breakpoint set.",
"domain": "DOMDebugger",
"description": "DOM debugging allows setting breakpoints on particular DOM operations and events. JavaScript execution will stop on these operations as if there was a regular breakpoint set.",
"commands": [
{
"name": "setDOMBreakpoint",
......
......@@ -118,13 +118,13 @@ void InspectorController::connectFrontend()
m_inspectorClient,
#if ENABLE(OFFLINE_WEB_APPLICATIONS)
m_inspectorAgent->applicationCacheAgent(),
#endif
#if ENABLE(JAVASCRIPT_DEBUGGER)
m_inspectorAgent->browserDebuggerAgent(),
#endif
m_inspectorAgent->cssAgent(),
m_inspectorAgent->consoleAgent(),
m_inspectorAgent->domAgent(),
#if ENABLE(JAVASCRIPT_DEBUGGER)
m_inspectorAgent->browserDebuggerAgent(),
#endif
#if ENABLE(DOM_STORAGE)
m_inspectorAgent->domStorageAgent(),
#endif
......
......@@ -321,7 +321,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
this._addListElement(element, currentElement);
this._breakpointElements[url] = element;
if (enabled)
BrowserDebuggerAgent.setXHRBreakpoint(url);
DOMDebuggerAgent.setXHRBreakpoint(url);
},
_removeBreakpoint: function(url)
......@@ -333,7 +333,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
this._removeListElement(element);
delete this._breakpointElements[url];
if (element._checkboxElement.checked)
BrowserDebuggerAgent.removeXHRBreakpoint(url);
DOMDebuggerAgent.removeXHRBreakpoint(url);
},
_contextMenu: function(url, event)
......@@ -351,9 +351,9 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
_checkboxClicked: function(url, event)
{
if (event.target.checked)
BrowserDebuggerAgent.setXHRBreakpoint(url);
DOMDebuggerAgent.setXHRBreakpoint(url);
else
BrowserDebuggerAgent.removeXHRBreakpoint(url);
DOMDebuggerAgent.removeXHRBreakpoint(url);
this._saveBreakpoints();
},
......@@ -535,7 +535,7 @@ WebInspector.EventListenerBreakpointsSidebarPane.prototype = {
if (!breakpointItem)
return;
breakpointItem.checkbox.checked = true;
BrowserDebuggerAgent.setEventListenerBreakpoint(eventName);
DOMDebuggerAgent.setEventListenerBreakpoint(eventName);
this._updateCategoryCheckbox(breakpointItem.parent);
},
......@@ -545,7 +545,7 @@ WebInspector.EventListenerBreakpointsSidebarPane.prototype = {
if (!breakpointItem)
return;
breakpointItem.checkbox.checked = false;
BrowserDebuggerAgent.removeEventListenerBreakpoint(eventName);
DOMDebuggerAgent.removeEventListenerBreakpoint(eventName);
this._updateCategoryCheckbox(breakpointItem.parent);
},
......
......@@ -200,7 +200,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
this._addListElement(element, currentElement);
this._breakpointElements[breakpointId] = element;
if (enabled)
BrowserDebuggerAgent.setDOMBreakpoint(node.id, type);
DOMDebuggerAgent.setDOMBreakpoint(node.id, type);
},
_removeBreakpoint: function(node, type)
......@@ -213,7 +213,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
this._removeListElement(element);
delete this._breakpointElements[breakpointId];
if (element._checkboxElement.checked)
BrowserDebuggerAgent.removeDOMBreakpoint(node.id, type);
DOMDebuggerAgent.removeDOMBreakpoint(node.id, type);
},
_contextMenu: function(node, type, event)
......@@ -231,9 +231,9 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
_checkboxClicked: function(node, type, event)
{
if (event.target.checked)
BrowserDebuggerAgent.setDOMBreakpoint(node.id, type);
DOMDebuggerAgent.setDOMBreakpoint(node.id, type);
else
BrowserDebuggerAgent.removeDOMBreakpoint(node.id, type);
DOMDebuggerAgent.removeDOMBreakpoint(node.id, type);
this._saveBreakpoints();
},
......
......@@ -88,7 +88,7 @@ macro_traits = {
"DOMStorage": "DOM_STORAGE",
"ApplicationCache": "OFFLINE_WEB_APPLICATIONS",
"Debugger": "JAVASCRIPT_DEBUGGER",
"BrowserDebugger": "JAVASCRIPT_DEBUGGER",
"DOMDebugger": "JAVASCRIPT_DEBUGGER",
"Profiler": "JAVASCRIPT_DEBUGGER",
"Worker": "WORKERS"
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment