Commit d81652c9 authored by xan@webkit.org's avatar xan@webkit.org

WebCore:

2010-11-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix IFrame DOM bindings API
        https://bugs.webkit.org/show_bug.cgi?id=49980

        Fix IFrame API naming. It needs special casing because of the two
        consecutive capital letters.

        * bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-11-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix IFrame DOM bindings API
        https://bugs.webkit.org/show_bug.cgi?id=49980

        * tests/testdomdocument.c:
        (test_dom_document_garbage_collection): change to use the fixed
        IFrame APIs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 20e2e9ca
2010-11-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980
Fix IFrame API naming. It needs special casing because of the two
consecutive capital letters.
* bindings/scripts/CodeGeneratorGObject.pm:
2010-11-23 Shimeng (Simon) Wang <swang@google.com>
Reviewed by Steve Block.
......@@ -110,6 +110,7 @@ sub FixUpDecamelizedName {
# FIXME: try to merge this somehow with the fixes in ClassNameToGobjectType
$classname =~ s/x_path/xpath/;
$classname =~ s/web_kit/webkit/;
$classname =~ s/htmli_frame/html_iframe/;
return $classname;
}
......@@ -118,8 +119,8 @@ sub ClassNameToGObjectType {
my $className = shift;
my $CLASS_NAME = uc(decamelize($className));
# Fixup: with our prefix being 'WebKitDOM' decamelize can't get
# WebKitDOMCSS right, so we have to fix it manually (and there
# might be more like this in the future)
# WebKitDOMCSS and similar names right, so we have to fix it
# manually.
$CLASS_NAME =~ s/DOMCSS/DOM_CSS/;
$CLASS_NAME =~ s/DOMHTML/DOM_HTML/;
$CLASS_NAME =~ s/DOMDOM/DOM_DOM/;
......@@ -127,6 +128,7 @@ sub ClassNameToGObjectType {
$CLASS_NAME =~ s/DOMX_PATH/DOM_XPATH/;
$CLASS_NAME =~ s/DOM_WEB_KIT/DOM_WEBKIT/;
$CLASS_NAME =~ s/DOMUI/DOM_UI/;
$CLASS_NAME =~ s/HTMLI_FRAME/HTML_IFRAME/;
return $CLASS_NAME;
}
......
2010-11-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980
* tests/testdomdocument.c:
(test_dom_document_garbage_collection): change to use the fixed
IFrame APIs.
2010-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
......
......@@ -263,13 +263,12 @@ static void test_dom_document_garbage_collection(DomDocumentFixture* fixture, gc
WebKitDOMElement* iframe = webkit_dom_document_get_element_by_id(document, "iframe");
g_assert(iframe);
/* FIXME: IFrame APIs have the 'i' in the wrong place */
webkit_dom_element_set_attribute(iframe, "src", "data:<html><head></head></html>", NULL);
while (g_main_context_pending(NULL))
g_main_context_iteration(NULL, FALSE);
WebKitDOMDocument* iframeDocument = webkit_dom_htmli_frame_element_get_content_document(WEBKIT_DOM_HTMLI_FRAME_ELEMENT(iframe));
WebKitDOMDocument* iframeDocument = webkit_dom_html_iframe_element_get_content_document(WEBKIT_DOM_HTML_IFRAME_ELEMENT(iframe));
g_assert(iframeDocument);
head = webkit_dom_document_get_head(iframeDocument);
g_assert(head);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment