Commit d10d6685 authored by hans@chromium.org's avatar hans@chromium.org
Browse files

2011-01-25 Hans Wennborg <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. The previous use was
        to signal to the embedder that IndexedDB was shutting down, but we
        agreed it is better if the embedder keeps track of that itself.

        No new tests: this does not change any functionality.

        * platform/chromium/PlatformBridge.h:
        * storage/IDBFactoryBackendInterface.cpp:
        * storage/IDBFactoryBackendInterface.h:
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. Chromium keeps track
        of when it shuts down IndexedDB itself.

        * public/WebKitClient.h:
        * src/PlatformBridge.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 72ef29bb
2011-01-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077
Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.
No new tests: this does not change any functionality.
* platform/chromium/PlatformBridge.h:
* storage/IDBFactoryBackendInterface.cpp:
* storage/IDBFactoryBackendInterface.h:
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25 Darin Adler <darin@apple.com>
 
Reviewed by Anders Carlsson.
......@@ -171,7 +171,6 @@ public:
// IndexedDB ----------------------------------------------------------
static PassRefPtr<IDBFactoryBackendInterface> idbFactory();
static void idbShutdown();
// Extracts keyPath from values and returns the corresponding keys.
static void createIDBKeysFromSerializedValuesAndKeyPath(const Vector<RefPtr<SerializedScriptValue> >& values, const String& keyPath, Vector<RefPtr<IDBKey> >& keys);
......
......@@ -43,10 +43,6 @@ PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
return IDBFactoryBackendImpl::create();
}
IDBFactoryBackendInterface::~IDBFactoryBackendInterface()
{
}
} // namespace WebCore
#endif // ENABLE(INDEXED_DATABASE)
......@@ -49,7 +49,7 @@ class SecurityOrigin;
class IDBFactoryBackendInterface : public ThreadSafeShared<IDBFactoryBackendInterface> {
public:
static PassRefPtr<IDBFactoryBackendInterface> create();
virtual ~IDBFactoryBackendInterface();
virtual ~IDBFactoryBackendInterface() { }
virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize) = 0;
};
......
......@@ -39,11 +39,6 @@ PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
return PlatformBridge::idbFactory();
}
IDBFactoryBackendInterface::~IDBFactoryBackendInterface()
{
PlatformBridge::idbShutdown();
}
} // namespace WebCore
#endif // ENABLE(INDEXED_DATABASE)
2011-01-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077
Since Chromium r72157, this is not used anymore. Chromium keeps track
of when it shuts down IndexedDB itself.
* public/WebKitClient.h:
* src/PlatformBridge.cpp:
2011-01-25 Ilya Sherman <isherman@chromium.org>
 
Reviewed by Darin Fisher.
......@@ -143,7 +143,6 @@ public:
// Indexed Database ----------------------------------------------------
virtual WebIDBFactory* idbFactory() { return 0; }
virtual void idbShutdown() { };
virtual void createIDBKeysFromSerializedValuesAndKeyPath(const WebVector<WebSerializedScriptValue>& values, const WebString& keyPath, WebVector<WebIDBKey>& keys) { }
......
......@@ -509,12 +509,6 @@ PassRefPtr<IDBFactoryBackendInterface> PlatformBridge::idbFactory()
return IDBFactoryBackendProxy::create();
}
void PlatformBridge::idbShutdown()
{
// In the browser process, this shuts down the utility process. In the renderer process, it does nothing.
webKitClient()->idbShutdown();
}
void PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath(const Vector<RefPtr<SerializedScriptValue> >& values, const String& keyPath, Vector<RefPtr<IDBKey> >& keys)
{
WebVector<WebSerializedScriptValue> webValues = values;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment