Commit d0175992 authored by darin@apple.com's avatar darin@apple.com
Browse files

2008-11-03 Darin Adler <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * Scripts/check-for-exit-time-destructors: Added.
        Started as a copy of check-for-global-initializers.

        * Scripts/check-for-global-initializers: Added code to make
        this script rerun any time it's modified, and also to properly
        run again after the first time it reports an error.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 9b4c9743
2008-11-03 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
- https://bugs.webkit.org/show_bug.cgi?id=22061
create script to check for exit-time destructors
* Scripts/check-for-exit-time-destructors: Added.
Started as a copy of check-for-global-initializers.
* Scripts/check-for-global-initializers: Added code to make
this script rerun any time it's modified, and also to properly
run again after the first time it reports an error.
2008-11-03 Pierre-Olivier Latour <pol@apple.com>
 
Reviewed by Dan Bernstein.
......
#!/usr/bin/perl
# Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
# its contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
# "check-for-exit-time-destructors" script for WebKit Open Source Project
# Intended to be invoked from an Xcode build step to check if there are
# any exit-time destructors in a target.
use warnings;
use strict;
use File::Basename;
sub touch($);
sub printFunctions($$);
my $arch = $ENV{'CURRENT_ARCH'};
my $configuration = $ENV{'CONFIGURATION'};
my $target = $ENV{'TARGET_NAME'};
my $variant = $ENV{'CURRENT_VARIANT'};
my $coverageBuild = $ENV{'WEBKIT_COVERAGE_BUILD'};
my $debugRoot = $ENV{'WEBKIT_DEBUG_ROOT'};
$arch = $ENV{'NATIVE_ARCH'} if !$arch; # for Xcode 2.1, which does not have CURRENT_ARCH
$variant = "normal" if !$variant; # for Xcode 2.1, which does not have CURRENT_VARIANT
my $executablePath = "$ENV{'TARGET_BUILD_DIR'}/$ENV{'EXECUTABLE_PATH'}";
my $buildTimestampPath = $ENV{'TARGET_TEMP_DIR'} . "/" . basename($0) . ".timestamp";
my $buildTimestampAge = -M $buildTimestampPath;
my $scriptAge = -M $0;
my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
if (!open LIST, $list) {
print "Could not open $list\n";
exit 1;
}
my @files = <LIST>;
chomp @files;
close LIST;
my $sawError = 0;
for my $file (sort @files) {
if (defined $buildTimestampAge && $buildTimestampAge < $scriptAge) {
my $fileAge = -M $file;
next if defined $fileAge && $fileAge > $buildTimestampAge;
}
if (!open NM, "(nm '$file' | sed 's/^/STDOUT:/') 2>&1 |") {
print "Could not open $file\n";
$sawError = 1;
next;
}
my $sawAtExit = 0;
while (<NM>) {
if (/^STDOUT:/) {
$sawAtExit = 1 if /___cxa_atexit/;
} else {
print STDERR if $_ ne "nm: no name list\n";
}
}
close NM;
next unless $sawAtExit;
my $shortName = $file;
$shortName =~ s/.*\///;
if ($target eq "WebCore") {
next if $shortName eq "AccessibilityObject.o";
next if $shortName eq "AccessibilityRenderObject.o";
next if $shortName eq "ApplicationCacheStorage.o";
next if $shortName eq "ApplyStyleCommand.o";
next if $shortName eq "ArchiveFactory.o";
next if $shortName eq "CSSMutableStyleDeclaration.o";
next if $shortName eq "CSSPrimitiveValue.o";
next if $shortName eq "CSSSelector.o";
next if $shortName eq "CSSStyleSelector.o";
next if $shortName eq "CachedImage.o";
next if $shortName eq "ColorMac.o";
next if $shortName eq "DOMImplementation.o";
next if $shortName eq "Document.o";
next if $shortName eq "EventHandler.o";
next if $shortName eq "EventHandlerMac.o";
next if $shortName eq "FTPDirectoryDocument.o";
next if $shortName eq "FontCache.o";
next if $shortName eq "FontCacheMac.o";
next if $shortName eq "FormDataStreamMac.o";
next if $shortName eq "Frame.o";
next if $shortName eq "FrameLoader.o";
next if $shortName eq "FrameMac.o";
next if $shortName eq "GCController.o";
next if $shortName eq "GraphicsContextMac.o";
next if $shortName eq "HTMLButtonElement.o";
next if $shortName eq "HTMLElement.o";
next if $shortName eq "HTMLFieldSetElement.o";
next if $shortName eq "HTMLInputElement.o";
next if $shortName eq "HTMLInterchange.o";
next if $shortName eq "HTMLKeygenElement.o";
next if $shortName eq "HTMLLegendElement.o";
next if $shortName eq "HTMLOptGroupElement.o";
next if $shortName eq "HTMLOptionElement.o";
next if $shortName eq "HTMLParser.o";
next if $shortName eq "HTMLSelectElement.o";
next if $shortName eq "HTMLTableElement.o";
next if $shortName eq "HTMLTextAreaElement.o";
next if $shortName eq "IconDatabase.o";
next if $shortName eq "Image.o";
next if $shortName eq "IndentOutdentCommand.o";
next if $shortName eq "InspectorController.o";
next if $shortName eq "JSDOMBinding.o";
next if $shortName eq "JSHTMLElementWrapperFactory.o";
next if $shortName eq "JSInspectedObjectWrapper.o";
next if $shortName eq "JSInspectorCallbackWrapper.o";
next if $shortName eq "JSSVGElementWrapperFactory.o";
next if $shortName eq "JavaScriptDebugServer.o";
next if $shortName eq "JavaScriptProfile.o";
next if $shortName eq "JavaScriptProfileNode.o";
next if $shortName eq "KURL.o";
next if $shortName eq "LocalStorage.o";
next if $shortName eq "NetworkStateNotifier.o";
next if $shortName eq "Page.o";
next if $shortName eq "PasteboardMac.o";
next if $shortName eq "RenderBlock.o";
next if $shortName eq "RenderCounter.o";
next if $shortName eq "RenderFlexibleBox.o";
next if $shortName eq "RenderLayer.o";
next if $shortName eq "RenderListItem.o";
next if $shortName eq "RenderScrollbarTheme.o";
next if $shortName eq "RenderStyle.o";
next if $shortName eq "RenderThemeMac.o";
next if $shortName eq "ReplaceSelectionCommand.o";
next if $shortName eq "ResourceResponseMac.o";
next if $shortName eq "SVGAnimateMotionElement.o";
next if $shortName eq "SVGAnimationElement.o";
next if $shortName eq "SVGLangSpace.o";
next if $shortName eq "SVGResource.o";
next if $shortName eq "SVGResourceMarker.o";
next if $shortName eq "SVGSMILElement.o";
next if $shortName eq "SVGSVGElement.o";
next if $shortName eq "SVGStyleElement.o";
next if $shortName eq "SVGTextContentElement.o";
next if $shortName eq "ScriptElement.o";
next if $shortName eq "ScrollView.o";
next if $shortName eq "ScrollbarThemeMac.o";
next if $shortName eq "SecurityOrigin.o";
next if $shortName eq "SimpleFontDataMac.o";
next if $shortName eq "TextEncoding.o";
next if $shortName eq "ThemeMac.o";
next if $shortName eq "ThreadCheck.o";
next if $shortName eq "XMLHttpRequest.o";
next if $shortName eq "XPathExpressionNode.o";
next if $shortName eq "XPathParser.o";
next if $shortName eq "XPathValue.o";
next if $shortName eq "bidi.o";
next if $shortName eq "htmlediting.o";
next if $shortName eq "markup.o";
next if $shortName eq "runtime_root.o";
}
if ($target eq "WebKit") {
next if $shortName eq "AccessibilityObject.o";
next if $shortName eq "WebBackForwardList.o";
next if $shortName eq "WebBaseNetscapePluginStream.o";
next if $shortName eq "WebHTMLRepresentation.o";
next if $shortName eq "WebHistoryItem.o";
next if $shortName eq "WebNSPasteboardExtras.o";
next if $shortName eq "WebPasteboardHelper.o";
next if $shortName eq "WebStringTruncator.o";
next if $shortName eq "WebView.o";
}
$sawError = 1 if printFunctions($shortName, $file);
}
if ($sawError and !$coverageBuild) {
unlink $executablePath;
exit 1;
}
touch($buildTimestampPath);
exit 0;
sub touch($)
{
my ($path) = @_;
open(TOUCH, ">", $path) or die "$!";
close(TOUCH);
}
sub demangle($)
{
my ($symbol) = @_;
if (!open FILT, "c++filt $symbol |") {
print "Could not open c++filt\n";
return;
}
my $result = <FILT>;
close FILT;
chomp $result;
return $result;
}
sub printFunctions($$)
{
my ($shortName, $path) = @_;
if (!open OTOOL, "otool -tV '$path' |") {
print "Could not open $path\n";
return 0;
}
my %functions;
my $currentSymbol = "";
while (<OTOOL>) {
$currentSymbol = $1 if /^(\w+):$/;
$functions{demangle($currentSymbol)} = 1 if /___cxa_atexit/;
}
close OTOOL;
my $result = 0;
for my $function (sort keys %functions) {
if (!$result) {
print "$shortName has exit time destructors in it! ($path)\n";
$result = 1;
}
print " $function\n";
}
return $result;
}
......@@ -52,8 +52,7 @@ my $executablePath = "$ENV{'TARGET_BUILD_DIR'}/$ENV{'EXECUTABLE_PATH'}";
my $buildTimestampPath = $ENV{'TARGET_TEMP_DIR'} . "/" . basename($0) . ".timestamp";
my $buildTimestampAge = -M $buildTimestampPath;
touch($buildTimestampPath);
my $scriptAge = -M $0;
my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
......@@ -69,7 +68,7 @@ close LIST;
my $sawError = 0;
for my $file (sort @files) {
if (defined $buildTimestampAge) {
if (defined $buildTimestampAge && $buildTimestampAge < $scriptAge) {
my $fileAge = -M $file;
next if defined $fileAge && $fileAge > $buildTimestampAge;
}
......@@ -125,6 +124,7 @@ if ($sawError and !$coverageBuild) {
exit 1;
}
touch($buildTimestampPath);
exit 0;
sub touch($)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment