Commit cf58e8c3 authored by dpranke@chromium.org's avatar dpranke@chromium.org

2010-05-18 Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Attempt to revert r58765 to see if it was causing a performance
        regression.

        https://bugs.webkit.org/show_bug.cgi?id=39328

        * fast/notifications/notifications-replace-expected.txt: Removed.
        * fast/notifications/notifications-replace.html: Removed.
        * fast/notifications/notifications-rtl-expected.txt: Removed.
        * fast/notifications/notifications-rtl.html: Removed.
2010-05-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Attempt to revert r58765 to see if it was causing a performance
        regression.

        https://bugs.webkit.org/show_bug.cgi?id=39328

        * notifications/Notification.h:
        * notifications/Notification.idl:
2010-05-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Attempt to revert r58765 to see if it was causing a performance
        regression.

        https://bugs.webkit.org/show_bug.cgi?id=39328

        * public/WebNotification.h:
        * src/WebNotification.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3a0bf1f8
2010-05-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Attempt to revert r58765 to see if it was causing a performance
regression.
https://bugs.webkit.org/show_bug.cgi?id=39328
* fast/notifications/notifications-replace-expected.txt: Removed.
* fast/notifications/notifications-replace.html: Removed.
* fast/notifications/notifications-rtl-expected.txt: Removed.
* fast/notifications/notifications-rtl.html: Removed.
2010-05-19 Martin Robinson <mrobinson@igalia.com>
Not reviewed.
DESKTOP NOTIFICATION: icon file:///email.png, title New E-mail, text Meet me tonight at 8!
DESKTOP NOTIFICATION: icon file:///alarm.png, title Alarm, text It's time to wake up!
REPLACING NOTIFICATION New E-mail
DESKTOP NOTIFICATION: icon file:///email.png, title New reply, text Correction, 8:15
Showing notifications with replace ID...
<!DOCTYPE html>
<html>
<head>
<script type="text/javascript">
function log(message)
{
document.getElementById("result").innerHTML += message + "<br>";
}
function runTests()
{
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission("file://");
layoutTestController.dumpAsText();
}
if (!window.webkitNotifications) {
log("FAIL: No webkitNotifications interface!");
}
var M = window.webkitNotifications.createNotification("/email.png", "New E-mail", "Meet me tonight at 8!");
M.replaceId = "NewMail";
M.show();
var other = window.webkitNotifications.createNotification("/alarm.png", "Alarm", "It's time to wake up!");
other.show();
var N = window.webkitNotifications.createNotification("/email.png", "New reply", "Correction, 8:15");
N.replaceId = "NewMail";
N.show();
}
</script>
</head>
<body>
<p>Showing notifications with replace ID...</p>
<div id="result"></div>
<script type="text/javascript">
runTests();
</script>
</body>
</html>
DESKTOP NOTIFICATION:(RTL) icon , title New E-mail, text Meet me tonight at 8!
Showing a notification with direction "rtl"...
<!DOCTYPE html>
<html>
<head>
<script type="text/javascript">
function log(message)
{
document.getElementById("result").innerHTML += message + "<br>";
}
function runTests()
{
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission("file://");
layoutTestController.dumpAsText();
}
if (!window.webkitNotifications) {
log("FAIL: No webkitNotifications interface!");
}
var M = window.webkitNotifications.createNotification("", "New E-mail", "Meet me tonight at 8!");
M.dir = "rtl";
M.show();
}
</script>
</head>
<body>
<p>Showing a notification with direction "rtl"...</p>
<div id="result"></div>
<script type="text/javascript">
runTests();
</script>
</body>
</html>
2010-05-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Attempt to revert r58765 to see if it was causing a performance
regression.
https://bugs.webkit.org/show_bug.cgi?id=39328
* notifications/Notification.h:
* notifications/Notification.idl:
2010-05-19 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
......@@ -68,11 +68,6 @@ namespace WebCore {
KURL iconURL() { return m_contents.icon(); }
NotificationContents& contents() { return m_contents; }
String dir() const { return m_direction; }
void setDir(const String& dir) { m_direction = dir; }
String replaceId() const { return m_replaceId; }
void setReplaceId(const String& replaceId) { m_replaceId = replaceId; }
DEFINE_ATTRIBUTE_EVENT_LISTENER(display);
DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
......@@ -98,9 +93,6 @@ namespace WebCore {
KURL m_notificationURL;
NotificationContents m_contents;
String m_direction;
String m_replaceId;
bool m_isShowing;
NotificationPresenter* m_presenter;
......
......@@ -42,9 +42,6 @@ module threads {
attribute EventListener onerror;
attribute EventListener onclose;
attribute DOMString dir;
attribute DOMString replaceId;
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
......
2010-05-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Attempt to revert r58765 to see if it was causing a performance
regression.
https://bugs.webkit.org/show_bug.cgi?id=39328
* public/WebNotification.h:
* src/WebNotification.cpp:
2010-05-19 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
......
......@@ -75,9 +75,6 @@ public:
WEBKIT_API WebString title() const;
WEBKIT_API WebString body() const;
WEBKIT_API WebString dir() const;
WEBKIT_API WebString replaceId() const;
// Called to indicate the notification has been displayed.
WEBKIT_API void dispatchDisplayEvent();
......
......@@ -94,16 +94,6 @@ WebString WebNotification::body() const
return m_private->contents().body();
}
WebString WebNotification::dir() const
{
return m_private->dir();
}
WebString WebNotification::replaceId() const
{
return m_private->replaceId();
}
void WebNotification::dispatchDisplayEvent()
{
RefPtr<Event> event = Event::create("display", false, true);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment