Commit ce6f6df4 authored by sullivan's avatar sullivan
Browse files

2002-11-13 John Sullivan <sullivan@apple.com>

	- fixed 3099922 -- REGRESSION: Back button always pops up menu

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
	Fixed a copy/paste error I made yesterday -- this method was never
	noticing the mouse-up events because it was checking the event type
	against the wrong number. Also changed the hysteresis values from
	unsigneds to floats (unsigned was just wrong).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 368154da
2002-11-13 John Sullivan <sullivan@apple.com>
- fixed 3099922 -- REGRESSION: Back button always pops up menu
* Misc.subproj/WebNSViewExtras.h:
* Misc.subproj/WebNSViewExtras.m:
(-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
Fixed a copy/paste error I made yesterday -- this method was never
noticing the mouse-up events because it was checking the event type
against the wrong number. Also changed the hysteresis values from
unsigneds to floats (unsigned was just wrong).
2002-11-13 Maciej Stachowiak <mjs@apple.com>
 
- fixed 3050447 - Policy handlers have no way of telling client
......
2002-11-13 John Sullivan <sullivan@apple.com>
- fixed 3099922 -- REGRESSION: Back button always pops up menu
* Misc.subproj/WebNSViewExtras.h:
* Misc.subproj/WebNSViewExtras.m:
(-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
Fixed a copy/paste error I made yesterday -- this method was never
noticing the mouse-up events because it was checking the event type
against the wrong number. Also changed the hysteresis values from
unsigneds to floats (unsigned was just wrong).
2002-11-13 Maciej Stachowiak <mjs@apple.com>
 
- fixed 3050447 - Policy handlers have no way of telling client
......
......@@ -23,8 +23,8 @@
// returns NO, else returns YES.
- (BOOL)_web_dragShouldBeginFromMouseDown:(NSEvent *)mouseDownEvent
withExpiration:(NSDate *)expiration
xHysteresis:(unsigned)xHysteresis
yHysteresis:(unsigned)yHysteresis;
xHysteresis:(float)xHysteresis
yHysteresis:(float)yHysteresis;
// Calls _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis: with
// the default values for xHysteresis and yHysteresis
......
......@@ -50,8 +50,8 @@ - (WebView *)_web_parentWebView
/* Determine whether a mouse down should turn into a drag; started as copy of NSTableView code */
- (BOOL)_web_dragShouldBeginFromMouseDown:(NSEvent *)mouseDownEvent
withExpiration:(NSDate *)expiration
xHysteresis:(unsigned)xHysteresis
yHysteresis:(unsigned)yHysteresis
xHysteresis:(float)xHysteresis
yHysteresis:(float)yHysteresis
{
NSEvent *nextEvent, *firstEvent, *dragEvent, *mouseUp;
BOOL dragIt;
......@@ -88,7 +88,7 @@ - (BOOL)_web_dragShouldBeginFromMouseDown:(NSEvent *)mouseDownEvent
dragIt = YES;
break;
}
} else if ([nextEvent type] == xHysteresis) {
} else if ([nextEvent type] == NSLeftMouseUp) {
mouseUp = nextEvent;
break;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment