Commit cce352d7 authored by barraclough@apple.com's avatar barraclough@apple.com

Crash on http://www.rickshawbags.com/

https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
        
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

* runtime/JSType.h:
    - sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
      and thus is excluded from isVariableObject() checks.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent a1ad8b75
2012-02-07 Gavin Barraclough <barraclough@apple.com>
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045
Reviewed by Darin Adler.
Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.
* runtime/JSType.h:
- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
and thus is excluded from isVariableObject() checks.
2012-02-06 Jer Noble <jer.noble@apple.com>
Use CMClock as a timing source for PlatformClock where available.
......@@ -49,11 +49,12 @@ enum JSType {
ErrorInstanceType,
GlobalThisType,
// VariableObjectType must come before all of the types of its subclasses and only its subclasses.
StaticScopeObjectType,
// VariableObjectType must be less than MOST of the types of its subclasses and only its subclasses.
// We use >=VariableObjectType checks to test for Global & Activation objects, but exclude StaticScopes.
VariableObjectType,
GlobalObjectType,
ActivationObjectType,
StaticScopeObjectType,
};
} // namespace JSC
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment