Fine tune Web Intents Chromium API

https://bugs.webkit.org/show_bug.cgi?id=76754

Patch by Greg Billock <gbillock@google.com> on 2012-01-23
Reviewed by Darin Fisher.

* public/WebIntent.h:
* public/WebIntentServiceInfo.h:
* src/WebIntent.cpp:
* src/WebIntentServiceInfo.cpp:
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 24b7c203
2012-01-23 Greg Billock <gbillock@google.com>
Fine tune Web Intents Chromium API
https://bugs.webkit.org/show_bug.cgi?id=76754
Reviewed by Darin Fisher.
* public/WebIntent.h:
* public/WebIntentServiceInfo.h:
* src/WebIntent.cpp:
* src/WebIntentServiceInfo.cpp:
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
2012-01-23 Shawn Singh <shawnsingh@chromium.org> 2012-01-23 Shawn Singh <shawnsingh@chromium.org>
[chromium] updateRect is incorrect when contentBounds != bounds [chromium] updateRect is incorrect when contentBounds != bounds
......
...@@ -62,9 +62,6 @@ public: ...@@ -62,9 +62,6 @@ public:
WEBKIT_EXPORT WebString type() const; WEBKIT_EXPORT WebString type() const;
WEBKIT_EXPORT WebString data() const; WEBKIT_EXPORT WebString data() const;
// FIXME: delete this.
WEBKIT_EXPORT int identifier() const;
#if WEBKIT_IMPLEMENTATION #if WEBKIT_IMPLEMENTATION
WebIntent(const WTF::PassRefPtr<WebCore::Intent>&); WebIntent(const WTF::PassRefPtr<WebCore::Intent>&);
#endif #endif
......
...@@ -67,6 +67,11 @@ public: ...@@ -67,6 +67,11 @@ public:
WEBKIT_EXPORT WebString disposition() const; WEBKIT_EXPORT WebString disposition() const;
WEBKIT_EXPORT void setDisposition(const WebString&); WEBKIT_EXPORT void setDisposition(const WebString&);
#if WEBKIT_IMPLEMENTATION
WebIntentServiceInfo(const WebString& action, const WebString& type, const WebURL& href,
const WebString& title, const WebString& disposition);
#endif
private: private:
WebString m_action; WebString m_action;
WebString m_type; WebString m_type;
......
...@@ -102,9 +102,4 @@ WebString WebIntent::data() const ...@@ -102,9 +102,4 @@ WebString WebIntent::data() const
#endif #endif
} }
int WebIntent::identifier() const
{
return 0;
}
} // namespace WebKit } // namespace WebKit
...@@ -83,4 +83,17 @@ void WebIntentServiceInfo::setDisposition(const WebString& disposition) ...@@ -83,4 +83,17 @@ void WebIntentServiceInfo::setDisposition(const WebString& disposition)
m_disposition = disposition; m_disposition = disposition;
} }
WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,
const WebString& type,
const WebURL& href,
const WebString& title,
const WebString& disposition)
: m_action(action)
, m_type(type)
, m_href(href)
, m_title(title)
, m_disposition(disposition)
{
}
} // namespace WebKit } // namespace WebKit
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment