Commit cb9cbb0b authored by andersca@apple.com's avatar andersca@apple.com

2008-05-28 Anders Carlsson <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/5819989> 
        Crash in WebKit!KJS::Window::printErrorMessage quitting Safari after pop up window on uk.real.com was closed

        Add null check for Frame::settings().
        
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::printErrorMessage):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d0c3574c
2008-05-28 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
<rdar://problem/5819989>
Crash in WebKit!KJS::Window::printErrorMessage quitting Safari after pop up window on uk.real.com was closed
Add null check for Frame::settings().
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::printErrorMessage):
2008-05-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Tim Hatcher.
......@@ -747,7 +747,11 @@ void JSDOMWindowBase::printErrorMessage(const String& message) const
if (!frame)
return;
if (frame->settings()->privateBrowsingEnabled())
Settings* settings = frame->settings();
if (!settings)
return;
if (settings->privateBrowsingEnabled())
return;
impl()->console()->addMessage(JSMessageSource, ErrorMessageLevel, message, 1, String()); // FIXME: provide a real line number and source URL.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment