Commit c8b6a2a3 authored by bdakin@apple.com's avatar bdakin@apple.com

2008-06-26 Beth Dakin <bdakin@apple.com>

        Reviewed by Anders.

        This is a speculative fix for the failing layout test on the build 
        bot. It seems that the problem that the Build Bot is having is 
        Tiger-specific. On Tiger, [NSValue description] was not very smart. 
        So I replaced our call to description with a hand-rolled equivalent 
        that will match on both platforms. 

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (descriptionOfValue):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 04dd6c3b
2008-06-26 Beth Dakin <bdakin@apple.com>
Reviewed by Anders.
This is a speculative fix for the failing layout test on the build
bot. It seems that the problem that the Build Bot is having is
Tiger-specific. On Tiger, [NSValue description] was not very smart.
So I replaced our call to description with a hand-rolled equivalent
that will match on both platforms.
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(descriptionOfValue):
2008-06-25 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
......
......@@ -344,14 +344,14 @@
isa = PBXGroup;
children = (
375F09710DAC3CB600C8B4E5 /* WebKitWeightWatcher100.ttf */,
375F09720DAC3CB600C8B4E5 /* WebKit_WeightWatcher200.ttf */,
375F09730DAC3CB600C8B4E5 /* WebKit_WeightWatcher300.ttf */,
375F09740DAC3CB600C8B4E5 /* WebKit_WeightWatcher400.ttf */,
375F09750DAC3CB600C8B4E5 /* WebKit_WeightWatcher500.ttf */,
375F09760DAC3CB600C8B4E5 /* WebKit_WeightWatcher600.ttf */,
375F09770DAC3CB600C8B4E5 /* WebKit_WeightWatcher700.ttf */,
375F09780DAC3CB600C8B4E5 /* WebKit_WeightWatcher800.ttf */,
375F09790DAC3CB600C8B4E5 /* WebKit_WeightWatcher900.ttf */,
375F09720DAC3CB600C8B4E5 /* WebKitWeightWatcher200.ttf */,
375F09730DAC3CB600C8B4E5 /* WebKitWeightWatcher300.ttf */,
375F09740DAC3CB600C8B4E5 /* WebKitWeightWatcher400.ttf */,
375F09750DAC3CB600C8B4E5 /* WebKitWeightWatcher500.ttf */,
375F09760DAC3CB600C8B4E5 /* WebKitWeightWatcher600.ttf */,
375F09770DAC3CB600C8B4E5 /* WebKitWeightWatcher700.ttf */,
375F09780DAC3CB600C8B4E5 /* WebKitWeightWatcher800.ttf */,
375F09790DAC3CB600C8B4E5 /* WebKitWeightWatcher900.ttf */,
AA7F10C20CB3C1030003BDC9 /* AHEM____.TTF */,
);
name = Resources;
......
......@@ -42,6 +42,22 @@ static NSString* descriptionOfValue(id valueObject, id focusedAccessibilityObjec
if ([valueObject isKindOfClass:[NSArray class]])
return [NSString stringWithFormat:@"<array of size %d>", [(NSArray*)valueObject count]];
if ([valueObject isKindOfClass:[NSNumber class]])
return [(NSNumber*)valueObject stringValue];
if ([valueObject isKindOfClass:[NSValue class]]) {
NSString* type = [NSString stringWithCString:[valueObject objCType] encoding:NSASCIIStringEncoding];
NSValue* value = (NSValue*)valueObject;
if ([type rangeOfString:@"NSRect"].length > 0)
return [NSString stringWithFormat:@"NSRect: %@", NSStringFromRect([value rectValue])];
if ([type rangeOfString:@"NSPoint"].length > 0)
return [NSString stringWithFormat:@"NSPoint: %@", NSStringFromPoint([value pointValue])];
if ([type rangeOfString:@"NSSize"].length > 0)
return [NSString stringWithFormat:@"NSSize: %@", NSStringFromSize([value sizeValue])];
if ([type rangeOfString:@"NSRange"].length > 0)
return [NSString stringWithFormat:@"NSRange: %@", NSStringFromRange([value rangeValue])];
}
// Strip absolute URL paths
NSString* description = [valueObject description];
NSRange range = [description rangeOfString:@"LayoutTests"];
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment