Commit c72ab915 authored by jam@chromium.org's avatar jam@chromium.org

2010-07-09 John Abd-El-Malek <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
        https://bugs.webkit.org/show_bug.cgi?id=42011

        * public/WebPlugin.h:
        (WebKit::WebPlugin::startFind):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 7c6786c3
2010-07-09 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
https://bugs.webkit.org/show_bug.cgi?id=42011
* public/WebPlugin.h:
(WebKit::WebPlugin::startFind):
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
......
......@@ -50,8 +50,8 @@ struct WebRect;
struct WebURLError;
template <typename T> class WebVector;
//FIXME: remove once the find functions below are rolled into chromium.
#define WEBPLUGIN_HAS_FIND_INTERFACE
// FIXME: remove once the chromium is updated.
#define WEBPLUGIN_FIND_HAS_RETURN_TYPE
class WebPlugin {
public:
......@@ -105,12 +105,11 @@ public:
virtual void setZoomFactor(float scale, bool textOnly) { }
// Find interface.
// Returns true if the plugin supports text search.
virtual bool supportsFind() { return false; }
// Start a new search. The plugin should search for a little bit at a time so that it
// doesn't block the thread in case of a large document. The results, along with the
// find's identifier, should be sent asynchronously to WebFrameClient's reportFindInPage* methods.
virtual void startFind(const WebString& searchText, bool caseSensitive, int identifier) { }
// Returns true if the search started, or false if the plugin doesn't support search.
virtual bool startFind(const WebString& searchText, bool caseSensitive, int identifier) { return false; }
// Tells the plugin to jump forward or backward in the list of find results.
virtual void selectFindResult(bool forward) { }
// Tells the plugin that the user has stopped the find operation.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment