Commit c43f0de4 authored by jamesr@google.com's avatar jamesr@google.com
Browse files

2010-04-02 James Robinson <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Remove an ASSERT that sometimes flakes due to time dependent animations
        https://bugs.webkit.org/show_bug.cgi?id=37048

        The outline repaint rectangle for a layer might change between two calls
        if there are animations involved, even if nothing in the DOM has actually
        changed between the calls.

        No change in behavior, no new tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent de5779b6
2010-04-02 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Remove an ASSERT that sometimes flakes due to time dependent animations
https://bugs.webkit.org/show_bug.cgi?id=37048
The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.
No change in behavior, no new tests.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
2010-04-02 Evan Stade <estade@chromium.org>
 
Reviewed by Adam Barth.
......@@ -318,7 +318,8 @@ void RenderLayer::updateLayerPositions(UpdateLayerPositionsFlags flags, IntPoint
RenderBoxModelObject* repaintContainer = renderer()->containerForRepaint();
IntRect newRect = renderer()->clippedOverflowRectForRepaint(repaintContainer);
IntRect newOutlineBox = renderer()->outlineBoundsForRepaint(repaintContainer, cachedOffset);
ASSERT(newOutlineBox == renderer()->outlineBoundsForRepaint(repaintContainer, 0));
// FIXME: Should ASSERT that value calculated for newOutlineBox using the cached offset is the same
// as the value not using the cached offset, but we can't due to https://bugs.webkit.org/show_bug.cgi?id=37048
if (flags & CheckForRepaint) {
if (view && !view->printing()) {
if (m_needsFullRepaint) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment