Commit c2257daa authored by dpranke@chromium.org's avatar dpranke@chromium.org
Browse files

2011-01-26 Dirk Pranke <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Fix regression introduced in r76322 ... new-run-webkit-tests
        was attempting to save the image diff output as a UTF-8-encoded
        file.

        https://bugs.webkit.org/show_bug.cgi?id=53210

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 99b7847a
2011-01-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
Fix regression introduced in r76322 ... new-run-webkit-tests
was attempting to save the image diff output as a UTF-8-encoded
file.
https://bugs.webkit.org/show_bug.cgi?id=53210
* Scripts/webkitpy/layout_tests/port/webkit.py:
2011-01-26 Sheriff Bot <webkit.review.bot@gmail.com> 2011-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
   
Unreviewed, rolling out r76709. Unreviewed, rolling out r76709.
...@@ -159,7 +159,7 @@ class WebKitPort(base.Port): ...@@ -159,7 +159,7 @@ class WebKitPort(base.Port):
if m.group(2) == 'passed': if m.group(2) == 'passed':
result = False result = False
elif output and diff_filename: elif output and diff_filename:
self._filesystem.write_text_file(diff_filename, output) self._filesystem.write_binary_file(diff_filename, output)
elif sp.timed_out: elif sp.timed_out:
_log.error("ImageDiff timed out") _log.error("ImageDiff timed out")
elif sp.crashed: elif sp.crashed:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment