Commit c19a7f85 authored by berto@igalia.com's avatar berto@igalia.com

REGRESSION(r160304): [GTK] Disable libtool fast install

https://bugs.webkit.org/show_bug.cgi?id=126381

Reviewed by Gustavo Noronha Silva.

.:

Don't disable the libtool fast-install mode unconditionally by
default.

If the fast-install mode is disabled, binaries are generated ready
to use the libraries directly from the build tree. If we use the
GNU linker, those binaries are then relinked when they are
installed.

However, libtool fails to do it properly when an installation
prefix is set with DESTDIR, and ends up installing the libtool
wrappers instead of the actual binaries.

* Source/autotools/SetupLibtool.m4:

Tools:

Disable the libtool fast-install mode in developer/test builds.

In this mode binaries are generated ready to be used directly from
the build tree. Otherwise they would need to be relinked when they
are executed, which can take a lot of resources, particularly in
debug builds.

* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b03eccd3
2014-01-08 Alberto Garcia <berto@igalia.com>
REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381
Reviewed by Gustavo Noronha Silva.
Don't disable the libtool fast-install mode unconditionally by
default.
If the fast-install mode is disabled, binaries are generated ready
to use the libraries directly from the build tree. If we use the
GNU linker, those binaries are then relinked when they are
installed.
However, libtool fails to do it properly when an installation
prefix is set with DESTDIR, and ends up installing the libtool
wrappers instead of the actual binaries.
* Source/autotools/SetupLibtool.m4:
2014-01-07 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Unreviewed GTK/CMake build fix: use the correct location for docs-build.stamp
......
......@@ -12,7 +12,6 @@ AC_SUBST([AR_FLAGS])
DOLT
AC_DISABLE_STATIC
AC_DISABLE_FAST_INSTALL
AC_LIBTOOL_WIN32_DLL
AC_PROG_LIBTOOL
2014-01-08 Alberto Garcia <berto@igalia.com>
REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381
Reviewed by Gustavo Noronha Silva.
Disable the libtool fast-install mode in developer/test builds.
In this mode binaries are generated ready to be used directly from
the build tree. Otherwise they would need to be relinked when they
are executed, which can take a lot of resources, particularly in
debug builds.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
2014-01-08 Zan Dobersek <zdobersek@igalia.com>
Unreviewed GTK gardening.
......
......@@ -1784,6 +1784,9 @@ sub runAutogenForAutotoolsProjectIfNecessary($@)
# Also, always enable developer mode for developer/test builds.
unshift(@buildArgs, "--enable-developer-mode");
# Optimize for running WebKit inside the build tree
unshift(@buildArgs, "--disable-fast-install");
my $joinedBuildArgs = join(" ", @buildArgs);
if (-e "GNUmakefile") {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment