Commit c0e0ec90 authored by weinig's avatar weinig
Browse files

Reviewed by Geoff Garen.

        Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html.  This change makes
        it pass on Windows so it can be removed from the Skipped list.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-properties.html:
        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 535998f2
2007-09-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html. This change makes
it pass on Windows so it can be removed from the Skipped list.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-properties.html:
* platform/win/Skipped:
2007-09-05 David Harrison <harrison@apple.com>
 
Reviewed by Kevin Decker.
......@@ -551,7 +551,6 @@ window.Event.prototype.SELECT [number]
window.Event.prototype.initEvent [function]
window.Event.prototype.preventDefault [function]
window.Event.prototype.stopPropagation [function]
window.GCController [object RuntimeObject]
window.HTMLAnchorElement [object HTMLAnchorElementConstructor]
window.HTMLAnchorElement.prototype [printed above as window.Element.prototype]
window.HTMLAppletElement [object HTMLAppletElementConstructor]
......@@ -884,7 +883,6 @@ window.XSLTProcessor.prototype.transformToDocument [function]
window.XSLTProcessor.prototype.transformToFragment [function]
window.addEventListener [function]
window.alert [function]
window.appleScriptController [object RuntimeObject]
window.atob [function]
window.blur [function]
window.btoa [function]
......@@ -918,7 +916,6 @@ window.defaultstatus [string]
window.devicePixelRatio [number]
window.document [printed above as window.Document.prototype]
window.event [undefined]
window.eventSender [object RuntimeObject]
window.find [function]
window.flushLog [function]
window.focus [function]
......@@ -957,10 +954,7 @@ window.menubar.visible [boolean]
window.moveBy [function]
window.moveTo [function]
window.name [string]
window.navigationController [object RuntimeObject]
window.navigator [printed above as window.clientInformation]
window.objCPlugin [object RuntimeObject]
window.objCPluginFunction [function]
window.offscreenBuffering [boolean]
window.onabort [null]
window.onbeforeunload [null]
......@@ -1028,7 +1022,6 @@ window.status [string]
window.statusbar [object BarInfo]
window.statusbar.visible [boolean]
window.stop [function]
window.textInputController [object RuntimeObject]
window.toolbar [object BarInfo]
window.toolbar.visible [boolean]
window.top [printed above as window]
......
......@@ -44,6 +44,22 @@ function typeStringNullAware(value)
: "[" + valueType + "]";
}
var __skip__ = {
"window.__skip__" : 1,
"window.opener" : 1, // Work around DumpRenderTree bug where previous tests add window properties
"window.Components" : 1, // Work around Firefox exception
// Don't log DumpRenderTree injected objects
"window.layoutTestController" : 1, // Work around http://bugs.webkit.org/show_bug.cgi?id=11373
"window.GCController" : 1,
"window.appleScriptController" : 1,
"window.eventSender" : 1,
"window.navigationController" : 1,
"window.objCPlugin" : 1,
"window.objCPluginFunction" : 1,
"window.textInputController" : 1
};
function logValue(valueName)
{
var value = tryEval(valueName);
......@@ -52,26 +68,17 @@ function logValue(valueName)
// Don't taint the test with our own variables
if (value == logBuffer || value == pre)
return;
// Don't taint the test with our own properties
if (/__visitedByLogValue__/.test(valueName) || /__nameWhenVisitedByLogValue__/.test(valueName))
return;
// Work around DumpRenderTree bug where previous tests add window properties
if ("window.opener" == valueName)
return;
// Work around http://bugs.webkit.org/show_bug.cgi?id=11373
if ("window.layoutTestController" == valueName)
if (__skip__[valueName])
return;
// Work around Firefox infinite recursion
if (/\.[0-9]/.test(valueName))
return;
// Work around Firefox exception
if ("window.Components" == valueName)
return;
// Avoid infinite recursion
if (valueType == "object" && value.__visitedByLogValue__) { //;
......@@ -80,7 +87,7 @@ function logValue(valueName)
}
log(valueName + " " + typeStringNullAware(value) + "\n");
if (valueType == "object") {
value.__visitedByLogValue__ = true;
value.__nameWhenVisitedByLogValue__ = valueName;
......
......@@ -587,9 +587,6 @@ fast/forms/input-truncate-newline.html
fast/forms/plaintext-mode-2.html
fast/forms/textarea-paste-newline.html
# Seems to be a difference btw. WebScriptObject and the JSCore API
fast/dom/Window/window-properties.html
# Unimplemented part of DRT. (This test is currently disabled).
# http/tests/plugins/npapi-response-headers.html
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment