Commit c0bb1500 authored by cfleizach@apple.com's avatar cfleizach@apple.com

AX: VoiceOver can't press on items

https://bugs.webkit.org/show_bug.cgi?id=114071

Reviewed by Tim Horton.

Source/WebCore:

The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.

Updated existing tests.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):

LayoutTests:

* platform/mac-future/accessibility: Added.
* platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
* platform/mac/accessibility/press-action-is-first-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 478b414b
2013-04-05 Chris Fleizach <cfleizach@apple.com>
AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071
Reviewed by Tim Horton.
* platform/mac-future/accessibility: Added.
* platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
* platform/mac/accessibility/press-action-is-first-expected.txt:
2013-04-05 Benjamin Poulain <bpoulain@apple.com>
Change css1/basic/comments-expected.html to be a ref-test
This tests that the AXPressAction comes first for activatable items instead of the scroll to visible action. This is needed for screenreaders to operate correctly.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Button supported actions: AXPress,AXShowMenu,AXScrollToVisible
Link supported actions: AXPress,AXShowMenu,AXScrollToVisible
PASS successfullyParsed is true
TEST COMPLETE
......@@ -4,8 +4,8 @@ This tests that the AXPressAction comes first for activatable items instead of t
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Button supported actions: AXPress,AXShowMenu,AXScrollToVisible
Link supported actions: AXPress,AXShowMenu,AXScrollToVisible
Button supported actions: AXPress,AXShowMenu
Link supported actions: AXPress,AXShowMenu
PASS successfullyParsed is true
TEST COMPLETE
......
2013-04-05 Chris Fleizach <cfleizach@apple.com>
AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071
Reviewed by Tim Horton.
The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.
Updated existing tests.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
2013-04-05 Anders Carlsson <andersca@apple.com>
Stop building Objective-C bindings for the SVG DOM
......@@ -925,11 +925,20 @@ static id textMarkerRangeFromVisiblePositions(AXObjectCache *cache, VisiblePosit
return nil;
// All elements should get ShowMenu and ScrollToVisible.
// But certain earlier VoiceOver versions do not support scroll to visible, and it confuses them to see it in the list.
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 1090
static NSArray *defaultElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityShowMenuAction, nil];
#else
static NSArray *defaultElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityShowMenuAction, NSAccessibilityScrollToVisibleAction, nil];
#endif
// Action elements allow Press.
// The order is important to VoiceOver, which expects the 'default' action to be the first action. In this case the default action should be press.
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 1090
static NSArray *actionElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityPressAction, NSAccessibilityShowMenuAction, nil];
#else
static NSArray *actionElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityPressAction, NSAccessibilityShowMenuAction, NSAccessibilityScrollToVisibleAction, nil];
#endif
// Menu elements allow Press and Cancel.
static NSArray *menuElementActions = [[actionElementActions arrayByAddingObject:NSAccessibilityCancelAction] retain];
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment