Commit be8aefa3 authored by thatcher's avatar thatcher

Reviewed by Harrison.

        <rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it

        Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
        This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply):
        (WebCore::EditCommand::unapply):
        (WebCore::EditCommand::reapply):
        (WebCore::applyCommand):
        * editing/EditCommand.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 961ceeb7
2006-11-17 Timothy Hatcher <timothy@apple.com>
Reviewed by Harrison.
<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it
Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
(WebCore::applyCommand):
* editing/EditCommand.h:
2006-11-17 Zack Rusin <zack@kde.org>
Reviewed by Mitz. Landed by Niko.
......@@ -85,12 +85,8 @@ void EditCommand::apply()
}
}
frame->editor()->deleteButtonController()->disable();
doApply();
frame->editor()->deleteButtonController()->enable();
// FIXME: Improve typing style.
// See this bug: <rdar://problem/3769899> Implementation of typing style needs improvement
if (!preservesTypingStyle()) {
......@@ -112,8 +108,6 @@ void EditCommand::unapply()
Frame* frame = m_document->frame();
frame->editor()->deleteButtonController()->disable();
doUnapply();
frame->editor()->deleteButtonController()->enable();
......@@ -130,13 +124,9 @@ void EditCommand::reapply()
ASSERT(m_document->frame());
Frame* frame = m_document->frame();
frame->editor()->deleteButtonController()->disable();
doReapply();
frame->editor()->deleteButtonController()->enable();
if (!m_parent) {
updateLayout();
frame->editor()->reappliedEditing(this);
......@@ -233,7 +223,10 @@ void EditCommand::setParent(CompositeEditCommand* parent)
void applyCommand(PassRefPtr<EditCommand> command)
{
DeleteButtonController *deleteButtonController = command->document()->frame()->editor()->deleteButtonController();
deleteButtonController->disable();
command->apply();
deleteButtonController->enable();
}
} // namespace WebCore
......@@ -83,6 +83,8 @@ private:
RefPtr<Element> m_endingRootEditableElement;
RefPtr<CSSMutableStyleDeclaration> m_typingStyle;
CompositeEditCommand* m_parent;
friend void applyCommand(PassRefPtr<EditCommand>);
};
void applyCommand(PassRefPtr<EditCommand>);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment