Web Inspector: Toolbar overflow appears outside window

https://bugs.webkit.org/show_bug.cgi?id=100663

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.

Since the search bar was removed from the toolbar, the overflow menu appears too far
to the right, and is unreadable. Fixed this by aligning it relative to the right side
of the window, rather than the left.

* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/inspector.css:
(#toolbar-dropdown .toolbar-label):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3015559a
2012-10-29 Patrick Dubroy <dubroy@chromium.org>
Web Inspector: Toolbar overflow appears outside window
https://bugs.webkit.org/show_bug.cgi?id=100663
Reviewed by Pavel Feldman.
Since the search bar was removed from the toolbar, the overflow menu appears too far
to the right, and is unreadable. Fixed this by aligning it relative to the right side
of the window, rather than the left.
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/inspector.css:
(#toolbar-dropdown .toolbar-label):
2012-10-29 Michelangelo De Simone <michelangelo@webkit.org>
[CSS Shaders] Implement CustomFilterArrayParameter::blend
......@@ -216,7 +216,7 @@ WebInspector.ToolbarDropdown.prototype = {
var top = this._arrow.totalOffsetTop() + this._arrow.clientHeight;
this._arrow.addStyleClass("dropdown-visible");
this.element.style.top = top + "px";
this.element.style.left = this._arrow.totalOffsetLeft() + "px";
this.element.style.right = window.innerWidth - this._arrow.totalOffsetLeft() - this._arrow.clientWidth + "px";
this._contentElement.style.maxHeight = window.innerHeight - top - 20 + "px";
this._toolbar.element.appendChild(this.element);
},
......
......@@ -245,6 +245,11 @@ body.undocked.platform-mac-snowleopard #toolbar-dropdown {
margin-right: 0.5em;
}
#toolbar-dropdown .toolbar-label {
line-height: 32px;
top: 0;
}
.scrollable-content {
position: static;
height: 100%;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment