Commit bb4455db authored by oliver@apple.com's avatar oliver@apple.com

Add a bunch of unhandled node types to the propagator

https://bugs.webkit.org/show_bug.cgi?id=68716

Reviewed by Darin Adler.

Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b99a6dfc
2011-09-23 Oliver Hunt <oliver@apple.com>
Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716
Reviewed by Darin Adler.
Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
2011-09-23 Mark Hahnenberg <mhahnenberg@apple.com>
Add static version of JSCell::visitChildren
......@@ -399,7 +399,12 @@ private:
break;
}
case ValueToDouble: {
// FIXME: should we predict double or number here?
break;
}
case ValueAdd: {
PredictedType left = m_predictions[node.child1()];
PredictedType right = m_predictions[node.child2()];
......@@ -588,6 +593,7 @@ private:
// These get ignored because they don't return anything.
case DFG::Jump:
case Branch:
case Breakpoint:
case Return:
case CheckHasInstance:
case Phi:
......@@ -599,6 +605,7 @@ private:
case Resolve:
case ResolveBase:
case ResolveBaseStrictPut:
case ResolveGlobal:
case PutScopedVar:
break;
......@@ -606,9 +613,7 @@ private:
case Phantom:
break;
default:
ASSERT_NOT_REACHED();
break;
#else
default:
break;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment