Commit ba165bd3 authored by darin@apple.com's avatar darin@apple.com

JavaScriptCore:

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        Fourth patch: Deal with the last few stray warnings.

        * parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
        This makes both separate compilation and all-in-one compilation work with the
        -Wredundant-decls warning.

WebCore:

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        Fourth patch: Deal with the last few stray warnings.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
        Also make the local variable be a RenderBlock so the cast is closer to the code
        that guarantees it's correct.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle): Put the enum into a local variable that's a built-in
        type before using it with TextStream, so we don't get a warning due to -Wsign-promo.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 2daec731
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
* parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
This makes both separate compilation and all-in-one compilation work with the
-Wredundant-decls warning.
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
......@@ -31,7 +31,9 @@
using std::auto_ptr;
#ifndef yyparse
extern int jscyyparse(void*);
#endif
namespace JSC {
......
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
Also make the local variable be a RenderBlock so the cast is closer to the code
that guarantees it's correct.
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle): Put the enum into a local variable that's a built-in
type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
......@@ -4325,7 +4325,7 @@ bool RenderBlock::containsNonZeroBidiLevel() const
RenderBlock* RenderBlock::firstLineBlock() const
{
const RenderObject* firstLineBlock = this;
RenderBlock* firstLineBlock = const_cast<RenderBlock*>(this);
bool hasPseudo = false;
while (true) {
hasPseudo = firstLineBlock->style()->hasPseudoStyle(RenderStyle::FIRST_LINE);
......@@ -4335,13 +4335,14 @@ RenderBlock* RenderBlock::firstLineBlock() const
if (firstLineBlock->isReplaced() || firstLineBlock->isFloating() ||
!parentBlock || parentBlock->firstChild() != firstLineBlock || !parentBlock->isBlockFlow())
break;
firstLineBlock = parentBlock;
ASSERT(parentBlock->isRenderBlock());
firstLineBlock = static_cast<RenderBlock*>(parentBlock);
}
if (!hasPseudo)
return 0;
return (RenderBlock*)(firstLineBlock);
return firstLineBlock;
}
void RenderBlock::updateFirstLetter()
......
......@@ -233,8 +233,10 @@ static void writeStyle(TextStream& ts, const RenderObject& object)
if (!object.localTransform().isIdentity())
ts << " [transform=" << object.localTransform() << "]";
if (svgStyle->imageRendering() != SVGRenderStyle::initialImageRendering())
ts << " [image rendering=" << svgStyle->imageRendering() << "]";
if (svgStyle->imageRendering() != SVGRenderStyle::initialImageRendering()) {
unsigned imageRenderingAsInteger = svgStyle->imageRendering();
ts << " [image rendering=" << imageRenderingAsInteger << "]";
}
if (style->opacity() != RenderStyle::initialOpacity())
ts << " [opacity=" << style->opacity() << "]";
if (object.isRenderPath()) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment