Commit b98c6454 authored by darin's avatar darin

Reviewed by Darin.

        - fix leaks caused by the fix for Bugzilla bug 3560

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with
        first-letter pseudo style are children of an existing first-letter inline
        that has been updated, and should be destroyed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 7905478e
2006-03-18 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin.
- fix leaks caused by the fix for Bugzilla bug 3560
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with
first-letter pseudo style are children of an existing first-letter inline
that has been updated, and should be destroyed.
2006-03-18 David Hyatt <hyatt@apple.com>
Fix for bug 7841, tables, table rows, and table row groups should
......@@ -64,7 +64,7 @@ void RenderContainer::destroy()
void RenderContainer::destroyLeftoverChildren()
{
while (m_first) {
if (m_first->isListMarker() || m_first->style()->styleType() == RenderStyle::FIRST_LETTER)
if (m_first->isListMarker() || (m_first->style()->styleType() == RenderStyle::FIRST_LETTER && !m_first->isText()))
m_first->remove(); // List markers are owned by their enclosing list and so don't get destroyed by this container. Similarly, first letters are destroyed by their remaining text fragment.
else {
// Destroy any anonymous children remaining in the render tree, as well as implicit (shadow) DOM elements like those used in the engine-based text fields.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment