Commit b6e784f0 authored by ap@webkit.org's avatar ap@webkit.org

Reviewed by Mark Rowe.

        Restore a collectOnMainThreadOnly call that was accidentally removed in r34659. It will not
        be needed when heaps are actually per-thread, but this isn't the case yet, and collecting
        on a different thread causes crashes.

        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObject::DOMObject):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 7f45a6b7
2008-06-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Mark Rowe.
Restore a collectOnMainThreadOnly call that was accidentally removed in r34659. It will not
be needed when heaps are actually per-thread, but this isn't the case yet, and collecting
on a different thread causes crashes.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
2008-06-22 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Darin Adler.
......@@ -49,6 +49,9 @@ namespace WebCore {
explicit DOMObject(KJS::JSValue* prototype) // FIXME: this should take a JSObject once JSLocation has a real prototype
: JSObject(prototype)
{
// DOMObject destruction is not thread-safe because DOMObjects wrap
// unsafe WebCore DOM data structures.
KJS::Heap::heap(this)->collectOnMainThreadOnly(this);
}
#ifndef NDEBUG
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment